feat(desktop): compress packaged app with xz by default#35440
Open
bartlomieju wants to merge 1 commit into
Open
feat(desktop): compress packaged app with xz by default#35440bartlomieju wants to merge 1 commit into
bartlomieju wants to merge 1 commit into
Conversation
Contributor
|
I understand the desire to get a low size, but the compressed by default will make users have many random stuff extracted in their disk (even if they're just experimenting), |
Contributor
|
if you're going with this default it would be great if you at least provide an env variable for this so I don't have to pass a flag each time, compression is an explicit choice when I'm done with the app and going to distribute it to the user maybe used only in ci even |
Packaging is now compressed by default. Building on the self-extracting support that was added recently, the `--compress` flag accepts `xz`, `zstd`, and `none`, and now defaults to `xz` so a bare `deno desktop` ships a compressed app. `xz` is decompressed by the system `tar` everywhere, while `zstd` is smaller and faster but needs the `zstd` tool at runtime. Passing `--compress none` ships the app uncompressed. The previous `lzma` alias is dropped (it normalized to `xz` anyway). Added unit tests covering the new default, explicit compressor selection, the `none` opt-out, and the bare `--compress` form.
7b5bc7d to
f7c0db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packaging is now compressed by default. Building on the self-extracting
support that was added recently, the
--compressflag acceptsxz,zstd, andnone, and now defaults toxzso a baredeno desktopships a compressed app.
xzis decompressed by the systemtareverywhere, while
zstdis smaller and faster but needs thezstdtoolat runtime. Passing
--compress noneships the app uncompressed. Theprevious
lzmaalias is dropped (it normalized toxzanyway).Added unit tests covering the new default, explicit compressor selection,
the
noneopt-out, and the bare--compressform.The webview-default change that previously lived here has been split out
into #35442.