Support zero day cooldown - #643
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Enables explicit zero-day cooldowns while rejecting negative values.
Changes:
- Uses pointer fields to distinguish zero from omitted values.
- Validates cooldown values before execution.
- Adds serialization and validation coverage.
Show a summary per file
| File | Description |
|---|---|
internal/model/job.go |
Updates cooldown fields and validation. |
internal/model/job_test.go |
Tests serialization and validation. |
internal/infra/run.go |
Validates cooldowns before running jobs. |
internal/infra/run_test.go |
Tests run-parameter validation. |
testdata/cooldown.yml |
Adds a zero-day cooldown fixture. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
jakecoffman
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cooldown day values of
0were silently dropped from the job payload. The fields wereintwithomitempty, so0was indistinguishable from unset:This makes
0a usable way to explicitly disable cooldown.Changes
UpdateCooldownday fields are now*int— explicit0serializes, unset stays omitted.UpdateCooldown.Validate()inextractInputto reject negative values, covering all input paths (file, args, server, stdin) forupdateandgraph.omitemptyis retained per the model-versioning guidance ininternal/model/job.go, so this stays compatible with dependabot-core before and after. No existing smoke tests set a zero cooldown.