Release v1.0.4 by nakkaa · Pull Request #98 · dev-hato/hato-bot

nakkaa · 2020-06-05T12:19:45Z

#79

Pythonファイルが差分に含まれないPRのLintはスキップする

Readmeにドキュメントへのリンクを追加

This reverts commit 9c74769

amesh kyotoコマンド削除

DockerのpostgresqlのSSL対応

コマンドで全角スペースを使えるようにする

import文をline-too-longの対象から除外

型ヒントのチェック用CI追加

テストファイル追加

lint修正

pr-lintの結果が空ならばコメントしない

github-actions · 2020-06-05T12:24:37Z

Lint結果だよ！🕊🕊🕊

************* Module create_env
create_env.py:52:0: C0301: Line too long (142/100) (line-too-long)
create_env.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module library.labotter
library/labotter.py:47:0: C0301: Line too long (135/100) (line-too-long)
library/labotter.py:1:0: C0114: Missing module docstring (missing-module-docstring)
library/labotter.py:8:0: C0115: Missing class docstring (missing-class-docstring)
library/labotter.py:20:8: W0702: No exception type(s) specified (bare-except)
library/labotter.py:26:29: W0622: Redefining built-in 'id' (redefined-builtin)
library/labotter.py:26:4: C0103: Argument name "id" doesn't conform to snake_case naming style (invalid-name)
library/labotter.py:26:4: C0116: Missing function or method docstring (missing-function-docstring)
library/labotter.py:33:32: W0622: Redefining built-in 'id' (redefined-builtin)
library/labotter.py:33:4: C0103: Argument name "id" doesn't conform to snake_case naming style (invalid-name)
library/labotter.py:33:4: C0116: Missing function or method docstring (missing-function-docstring)
library/labotter.py:42:30: W0622: Redefining built-in 'id' (redefined-builtin)
library/labotter.py:42:4: C0103: Argument name "id" doesn't conform to snake_case naming style (invalid-name)
library/labotter.py:42:4: C0116: Missing function or method docstring (missing-function-docstring)
library/labotter.py:49:12: W0702: No exception type(s) specified (bare-except)
library/labotter.py:55:32: W0622: Redefining built-in 'id' (redefined-builtin)
library/labotter.py:55:4: C0103: Argument name "id" doesn't conform to snake_case naming style (invalid-name)
library/labotter.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)
library/labotter.py:64:12: W0702: No exception type(s) specified (bare-except)
library/labotter.py:70:34: W0622: Redefining built-in 'id' (redefined-builtin)
library/labotter.py:70:4: C0103: Argument name "id" doesn't conform to snake_case naming style (invalid-name)
library/labotter.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)
library/labotter.py:80:12: W0702: No exception type(s) specified (bare-except)
library/labotter.py:86:44: W0622: Redefining built-in 'id' (redefined-builtin)
library/labotter.py:86:4: C0103: Argument name "id" doesn't conform to snake_case naming style (invalid-name)
library/labotter.py:86:4: C0116: Missing function or method docstring (missing-function-docstring)
library/labotter.py:110:11: C0121: Comparison to False should be 'not expr' (singleton-comparison)
library/labotter.py:130:11: C0121: Comparison to True should be just 'expr' (singleton-comparison)
library/labotter.py:134:12: C0103: Variable name "dt" doesn't conform to snake_case naming style (invalid-name)
library/labotter.py:2:0: C0411: standard import "import datetime" should be placed before "import pg8000" (wrong-import-order)
library/labotter.py:3:0: C0411: standard import "from typing import Tuple" should be placed before "import pg8000" (wrong-import-order)
************* Module library.vocabularydb
library/vocabularydb.py:1:0: C0114: Missing module docstring (missing-module-docstring)
library/vocabularydb.py:19:8: W0702: No exception type(s) specified (bare-except)
library/vocabularydb.py:31:12: W0702: No exception type(s) specified (bare-except)
library/vocabularydb.py:44:12: W0702: No exception type(s) specified (bare-except)
library/vocabularydb.py:57:12: W0702: No exception type(s) specified (bare-except)
library/vocabularydb.py:60:26: W0622: Redefining built-in 'id' (redefined-builtin)
library/vocabularydb.py:60:4: C0103: Argument name "id" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:67:12: W0702: No exception type(s) specified (bare-except)
library/vocabularydb.py:77:33: C0103: Variable name "z" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:80:4: R1705: Unnecessary "else" after "return" (no-else-return)
library/vocabularydb.py:80:7: C0122: Comparison should be len(result) > 0 (misplaced-comparison-constant)
library/vocabularydb.py:86:12: C0103: Variable name "no" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:86:12: W0612: Unused variable 'no' (unused-variable)
library/vocabularydb.py:100:33: C0103: Variable name "vd" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:104:20: W0622: Redefining built-in 'id' (redefined-builtin)
library/vocabularydb.py:104:0: C0103: Argument name "id" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:109:33: C0103: Variable name "vd" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:114:8: C0103: Variable name "no" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:114:8: W0612: Unused variable 'no' (unused-variable)
library/vocabularydb.py:127:33: C0103: Variable name "vd" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:136:22: W0622: Redefining built-in 'id' (redefined-builtin)
library/vocabularydb.py:136:0: C0103: Argument name "id" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:141:33: C0103: Variable name "vd" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:145:12: C0103: Variable name "no" doesn't conform to snake_case naming style (invalid-name)
library/vocabularydb.py:145:16: W0612: Unused variable 'text' (unused-variable)
************* Module plugins.hato
plugins/hato.py:24:0: C0301: Line too long (117/100) (line-too-long)
************* Module slackbot_settings
slackbot_settings.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module tests.plugins.test_hato
tests/plugins/test_hato.py:1:0: C0114: Missing module docstring (missing-module-docstring)
tests/plugins/test_hato.py:10:0: C0115: Missing class docstring (missing-class-docstring)
tests/plugins/test_hato.py:12:4: C0116: Missing function or method docstring (missing-function-docstring)
tests/plugins/test_hato.py:17:4: C0116: Missing function or method docstring (missing-function-docstring)
tests/plugins/test_hato.py:23:4: C0116: Missing function or method docstring (missing-function-docstring)
tests/plugins/test_hato.py:31:0: C0115: Missing class docstring (missing-class-docstring)
tests/plugins/test_hato.py:32:4: C0116: Missing function or method docstring (missing-function-docstring)
tests/plugins/test_hato.py:35:4: C0116: Missing function or method docstring (missing-function-docstring)
tests/plugins/test_hato.py:38:4: C0116: Missing function or method docstring (missing-function-docstring)
tests/plugins/test_hato.py:41:4: C0116: Missing function or method docstring (missing-function-docstring)
tests/plugins/test_hato.py:44:4: C0116: Missing function or method docstring (missing-function-docstring)
tests/plugins/test_hato.py:47:4: C0116: Missing function or method docstring (missing-function-docstring)
tests/plugins/test_hato.py:50:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module tests.test_slackbot_settings
tests/test_slackbot_settings.py:1:0: R0801: Similar lines in 2 files
==library.labotter:8
==library.vocabularydb:7
    def __init__(self):
        try:
            pg8000.paramstyle = 'qmark'
            self.conn = pg8000.connect(
                host=conf.DB_HOST,
                user=conf.DB_USER,
                password=conf.DB_PASSWORD,
                port=conf.DB_PORT,
                ssl_context=conf.DB_SSL,
                database=conf.DB_NAME
            )
        except:
            print('Can not connect to database.')

    def __enter__(self):
        return self
 (duplicate-code)
tests/test_slackbot_settings.py:1:0: R0801: Similar lines in 3 files
==create_env:10
==library.labotter:8
==library.vocabularydb:7
    def __init__(self):
        try:
            pg8000.paramstyle = 'qmark'
            self.conn = pg8000.connect(
                host=conf.DB_HOST,
                user=conf.DB_USER,
                password=conf.DB_PASSWORD,
                port=conf.DB_PORT,
                ssl_context=conf.DB_SSL,
                database=conf.DB_NAME
            )
        except:
            print('Can not connect to database.') (duplicate-code)

-----------------------------------
Your code has been rated at 8.14/10

massongit and others added 30 commits May 23, 2020 14:33

Skip lint when diff do not contain python files

b6349e6

Change name

c8e7e1e

Merge pull request #75 from nakkaa/fix_lint2

56854c4

Pythonファイルが差分に含まれないPRのLintはスキップする

Readmeにドキュメントへのリンクを追加

485f11d

文字抜け修正

040c5e4

Merge pull request #78 from nakkaa/update_readme

dfb78db

Readmeにドキュメントへのリンクを追加

Enable SSL

b32c343

Fix import

51a6efb

Change dir name

d62a6e2

Enable zenkaku space

0996a78

Fix comment

3a2e25d

Delete unnecessary process

d31373b

Add var

c83d2d8

Fix var name

6fc707d

Simplify commands

2a6b07d

Enable heading of zenkaku space

11e982a

Separate process to function

8506fbf

Delete amesh kyoto

3e5c1b6

Use respond_to_with_space

4d8791f

Add type hint

a032ea6

Add test file

be81647

Ignore import statements

aa4314a

Fix parameter

4c60345

Add test

b41147e

Fix

72e8399

Add test

169ec3d

Fix

828c843

add -v

9c74769

add __init__.py

fe903ce

Revert "add -v"

7074e50

This reverts commit 9c74769

massongit and others added 25 commits May 24, 2020 18:18

Fix type hints

5237778

Add mypy setting file

c82e94d

Separate CI

0b9386a

Fix type hints

ccb1db3

Fix .gitignore

b965d9c

Fix lint

a93a493

Fix exception

def8eb9

Fix

4ad3e42

Add mypy section

34409c7

Add type hints

1e285e8

Add type hint

a672d7a

Fix diff

eaa9503

Fix re

1277445

Add if

f48ffdf

Merge pull request #83 from nakkaa/remove_amesh_kyoto

d782c8b

amesh kyotoコマンド削除

Merge pull request #81 from nakkaa/enable_ssl

17312f1

DockerのpostgresqlのSSL対応

Merge branch 'develop' into enable_zenkaku_space

b173207

Merge pull request #82 from nakkaa/enable_zenkaku_space

7a3f9d3

コマンドで全角スペースを使えるようにする

Merge pull request #86 from nakkaa/ignore_long_line

a303e04

import文をline-too-longの対象から除外

Merge pull request #90 from nakkaa/add_mypy

a574c76

型ヒントのチェック用CI追加

Merge pull request #91 from nakkaa/add_test2

7a7847c

テストファイル追加

Merge pull request #92 from nakkaa/fix_diff

18ba73c

lint修正

Merge pull request #93 from nakkaa/do_not_comment

aaac578

pr-lintの結果が空ならばコメントしない

クレジット表記を追加

2c1ac14

v1.0.4

c2fd954

nakkaa temporarily deployed to hatbot June 5, 2020 12:21 Inactive

Merge branch 'master' into release_v1.0.4

dc51615

nakkaa merged commit f43ccb3 into master Jun 5, 2020

nakkaa deleted the release_v1.0.4 branch June 5, 2020 12:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v1.0.4#98

Release v1.0.4#98
nakkaa merged 64 commits intomasterfrom
release_v1.0.4

nakkaa commented Jun 5, 2020 •

edited

Loading

Uh oh!

github-actions bot commented Jun 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nakkaa commented Jun 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nakkaa commented Jun 5, 2020 •

edited

Loading