fleet: --tsan preflight must not trigger on --tsan-* sub-options (unblocks --concurrency-stress fleets) - #229
Merged
Merged
Conversation
…options The `cmd_check` glob `*--tsan*` matched `--tsan-threads` / `--tsan-iterations` (and `--tsan-dedup-*`), so a `--concurrency-stress` fleet -- which reuses those knobs but runs on an ORDINARY interpreter (no ThreadSanitizer build) -- wrongly tripped the "TARGET_PYTHON is not free-threaded + --with-thread-sanitizer" preflight and refused to start. Narrow the pattern to the bare `--tsan` mode flag (`*--tsan|*--tsan[!-]*`: `--tsan ` with a space, or ending the string; `[!-]` excludes the `--tsan-` sub-option forms), so real `--tsan` still requires a TSan target while `--concurrency-stress --tsan-threads N --tsan-iterations N` starts on any interpreter (e.g. RustPython). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Starting a
--concurrency-stressfleet fails the preflight:even though
--tsanis not set. Thecmd_checkcase glob*--tsan*matches--tsan-threads/--tsan-iterations— the knobs--concurrency-stresslegitimately reuses (from #226) to size its stress region.--concurrency-stressruns on an ordinary interpreter, so it must not require a ThreadSanitizer build.Fix
Narrow the build-check glob to the bare
--tsanmode flag:*--tsan|*--tsan[!-]*(matches--tsanwith a trailing space, or--tsanending the string;[!-]excludes the--tsan-sub-option forms). Verified:--concurrency-stress --tsan-threads 4 --tsan-iterations 200--tsan --tsan-threads 4(real TSan)--modules x --tsan(bare at end)--concurrency-stress --tsan-dedup-catalog=…(no bare --tsan)bash -n fleet/fleetclean.🤖 Generated with Claude Code