Skip to content

fleet: --tsan preflight must not trigger on --tsan-* sub-options (unblocks --concurrency-stress fleets) #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devdanzin merged 1 commit into from
Jul 20, 2026
Merged

fleet: --tsan preflight must not trigger on --tsan-* sub-options (unblocks --concurrency-stress fleets) #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion fleet/fleet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,12 @@ cmd_check(){ # validate fleet.conf before we start anything (catches the #1 foo
esac
# A --tsan fleet needs a free-threaded + ThreadSanitizer TARGET (fusil's own preflight fails
# fast otherwise, wasting the instance). Check here so the whole fleet doesn't start doomed.
# Match ONLY the bare `--tsan` mode flag, not the `--tsan-*` sub-options (--tsan-threads,
# --tsan-iterations, --tsan-dedup-*): those knobs are ALSO reused by --concurrency-stress, which
# runs on an ordinary interpreter and must NOT trip the ThreadSanitizer-build requirement. The
# bare flag appears as `--tsan ` (space) or ends the string; `[!-]` excludes the `--tsan-` forms.
case "$FUSIL_FLAGS" in
*--tsan*) [ -x "$TARGET_PYTHON" ] && "$TARGET_PYTHON" -c \
*--tsan|*--tsan[!-]*) [ -x "$TARGET_PYTHON" ] && "$TARGET_PYTHON" -c \
'import sys,sysconfig; ca=sysconfig.get_config_var("CONFIG_ARGS") or ""; sys.exit(0 if (not sys._is_gil_enabled() and "thread-sanitizer" in ca) else 1)' \
2>/dev/null || {
echo " --tsan is set but TARGET_PYTHON is not free-threaded + --with-thread-sanitizer: '$TARGET_PYTHON'"
Expand Down
Loading