Skip to content

Add clean command#1

Merged
developit merged 1 commit intodevelopit:masterfrom
fdaciuk:create-build-dir
Apr 7, 2016
Merged

Add clean command#1
developit merged 1 commit intodevelopit:masterfrom
fdaciuk:create-build-dir

Conversation

@fdaciuk
Copy link
Contributor

@fdaciuk fdaciuk commented Apr 7, 2016

Hey @developit! Are you kidding me? One more awesome project! Nice job :D

I needed to add a simple command before run npm start, because I was getting this error:

> dropfox@1.0.0 build:assets /code/dropfox
> ncp src/assets build/assets

There were errors during the copy.
Error: ENOENT: no such file or directory, mkdir '/code/dropfox/build/assets'

I think it doesn't work on Windows (at least, not in default cmd). I don't know what we can do in this case. Maybe use a NodeJS script to do the same thing. What do you think?

Remove old build directory and create it again
@developit
Copy link
Owner

Hmm - I haven't tested this on Windows yet. I'm thinking there are some file paths that need to be made dynamic. Are you still getting this error after adding the clean command?

@developit developit merged commit 5535c22 into developit:master Apr 7, 2016
@fdaciuk
Copy link
Contributor Author

fdaciuk commented Apr 7, 2016

No. After clean command, the app works well =)

@fdaciuk fdaciuk deleted the create-build-dir branch April 7, 2016 01:17
@developit
Copy link
Owner

oh wow, that's actually a huge surprise for me hahaha

@fdaciuk
Copy link
Contributor Author

fdaciuk commented Apr 7, 2016

Actually, I couldn't make the app to work yet. Just build it haha xD
I'm getting a 400 error =/

At the first load, the screen doesn't load anything:

selection_180

After to press Ctrl + R, the interface is shown, but with a 400 error in a popup:

selection_181

@developit
Copy link
Owner

Ahh, that's the API Key being mismatched to the redirect URI. In the Dropbox API console, make sure you have the URL https://dropfox.firebaseapp.com/dropbox/oauth_receiver.html whitelisted.

@fdaciuk
Copy link
Contributor Author

fdaciuk commented Apr 7, 2016

And now it works! 💃 💃 ✨

@developit
Copy link
Owner

WOOT!

@developit
Copy link
Owner

Now we just need @connors to make a photon variant that fits in a bit better on Windows & Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants