Support import JSX from JS file#571
Merged
bors[bot] merged 2 commits intodevelopit:masterfrom Mar 2, 2020
Merged
Conversation
developit
approved these changes
Feb 28, 2020
| nodeResolve({ | ||
| mainFields: ['module', 'jsnext', 'main'], | ||
| browser: options.target !== 'node', | ||
| extensions: ['.mjs', '.js', '.jsx', '.json', '.node'], |
Collaborator
There was a problem hiding this comment.
just kinda wondering if there could be problems with typescript, probably not because everything in node modules should already be compiled
Contributor
Author
There was a problem hiding this comment.
I just add jsx to the list of the default values, nothing should be different for TypeScript.
😄
Collaborator
|
bors r+ |
Contributor
Build succeeded |
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@rollup/plugin-node-resolvepluginBackground
I have experience an error when importing
.jsx filefrom.jsfile likewill cause an error
However, Importing
.jsxfile from TypeScript file (.ts) file is seems working fine except the the import is chaining more than 3 levels depth.To reproduce the issue
I'm not really sure what is the root cause of the error, by adding extensions seems to fix the problem.