Skip to content

Support import JSX from JS file #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Mar 2, 2020
Merged

Support import JSX from JS file #571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb78a4
Supply extensions to node-resolve plugin
n3tr Feb 28, 2020
875558b
Add comment
n3tr Mar 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,8 @@ function createConfig(options, entry, format, writeMeta) {
nodeResolve({
mainFields: ['module', 'jsnext', 'main'],
browser: options.target !== 'node',
// defaults + .jsx
extensions: ['.mjs', '.js', '.jsx', '.json', '.node'],
Copy link
Copy Markdown
Collaborator

@ForsakenHarmony ForsakenHarmony Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just kinda wondering if there could be problems with typescript, probably not because everything in node modules should already be compiled

Copy link
Copy Markdown
Contributor Author

@n3tr n3tr Mar 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just add jsx to the list of the default values, nothing should be different for TypeScript.
😄

}),
commonjs({
// use a regex to make sure to include eventual hoisted packages
Expand Down