feat(devframe): expose utils/get-port, drop plugin deps on get-port-please - #249
Merged
Conversation
…lease Re-export get-port-please's getPort through devframe/utils/get-port so plugins resolve a free port without each declaring their own get-port-please dependency. get-port-please stays a devframe devDependency, already bundled into its node build. Updates all nine plugins (a11y, assets, code-server, data-inspector, git, inspect, messages, og, terminals) plus a11y's demo server to import from the new util and drops their now-unused get-port-please dependency entries.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get-port-please'sgetPort(plusGetPortInput/GetPortOptions) through a newdevframe/utils/get-portentry, wired intopackages/devframe'sexportsmap and node-onlytsdownbuild.get-port-pleasestays adevframedevDependency, already bundled into its node build (deps.onlyBundle) — no new runtime dependency for consumers.a11y,assets,code-server,data-inspector,git,inspect,messages,og,terminals) now importsgetPortfromdevframe/utils/get-portinstead ofget-port-pleasedirectly, and drops the now-unusedget-port-pleasedependency entry from each plugin'spackage.json.tsnapiAPI snapshot for the newdevframe/utils/get-portexport.🤖 Generated with the help of an agent.