fix(hub-ui): support persistent toast notifications - #299
Merged
antfu merged 2 commits intoAug 27, 2026
Conversation
|
@dvcolomban is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the hub message/toast contract to support persistent toast notifications by allowing autoDismiss: false, and updates the hub-ui toast state logic + adds fake-timer tests to validate persistent vs timed behavior.
Changes:
- Update
DevframeMessageEntry.autoDismissto acceptfalse(persistent toast). - Update hub-ui toast timer handling to avoid scheduling (and to cancel) timers for persistent toasts.
- Add vitest fake-timer coverage for persistent, updated, and timed toast scenarios.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/snapshots/tsnapi/@devframes/hub/index.snapshot.d.ts | Updates public d.ts snapshot to reflect `autoDismiss?: number |
| packages/hub/src/types/messages.ts | Expands DevframeMessageEntry.autoDismiss type to include false for persistent toasts. |
| packages/hub-ui/src/client/state/toasts.ts | Cancels existing timers on toast updates and skips timer creation when autoDismiss === false. |
| packages/hub-ui/src/client/state/toasts.test.ts | Adds fake-timer tests for persistent vs timed toast behavior, including updating timed → persistent. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoDismiss: falsein the public message typeValidation
pnpm lintpnpm knippnpm test(117 files, 1,274 passed, 9 skipped)pnpm typecheck(38 tasks)pnpm build(27 tasks)