compiler: Fix topofusion to honour the closest scope#2970
Merged
Conversation
FabioLuporini
force-pushed
the
hotfix-topofuse-final
branch
from
July 10, 2026 21:25
5339f4d to
7eac827
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2970 +/- ##
==========================================
- Coverage 83.55% 83.55% -0.01%
==========================================
Files 257 257
Lines 53538 53558 +20
Branches 4584 4585 +1
==========================================
+ Hits 44735 44751 +16
- Misses 8010 8013 +3
- Partials 793 794 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FabioLuporini
force-pushed
the
hotfix-topofuse-final
branch
from
July 13, 2026 12:30
7eac827 to
78a5d1f
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
FabioLuporini
commented
Jul 13, 2026
|
|
||
|
|
||
| class Key(tuple): | ||
| class Keys(CacheInstances): |
Contributor
Author
There was a problem hiding this comment.
this is mostly just a refactoring, essentially to be able to access the last and first properties in the choose_element function later on
FabioLuporini
commented
Jul 13, 2026
| return self.c.guards if any(self.c.guards) else None | ||
|
|
||
| @cached_property | ||
| def syncs(self): |
Contributor
Author
There was a problem hiding this comment.
nothing new...
FabioLuporini
commented
Jul 13, 2026
| return (self.itintervals, self.guards, self.syncs) | ||
|
|
||
| @cached_property | ||
| def weak(self): |
Contributor
Author
There was a problem hiding this comment.
nothing new...
mloubout
approved these changes
Jul 13, 2026
FabioLuporini
force-pushed
the
hotfix-topofuse-final
branch
from
July 13, 2026 15:46
e3e332f to
7d91ac8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test in PRO