Auto-populate User.Number from Id when no phone number is provided - #408
Merged
Conversation
When constructing a User with a phone-number Id and no explicit number, Number is now automatically set to the normalized Id value. BSUID users are unaffected (Number stays null). Adds four new tests verifying the new behavior: - Phone Id with no number arg populates Number - Explicit null number behaves the same as omitting it - Leading + in Id is stripped when auto-populating Number - BSUID users with no number keep Number as null
kzu
enabled auto-merge (rebase)
May 2, 2026 02:05
Member
Author
|
🧪 Details on Ubuntu 24.04.4 LTSfrom retest v1.1.0 on .NET 10.0.7 with 💜 by @devlooped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When constructing a User with a phone-number Id and no explicit number, Number is now automatically set to the normalized Id value. BSUID users are unaffected (Number stays null).
Adds four new tests verifying the new behavior: