#1870: Add generic get-version implementation for global tools under windows - #2244
Open
vivu001 wants to merge 42 commits into
Open
Conversation
… entries from registry
Co-authored-by: MarvMa <marvin.meitzner@gmail.com>
…evonfw#1869-improve-windows-helper-to-search-windows-registry
…-tool' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
…tarts' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows # Conflicts: # CHANGELOG.adoc
…indows-registry' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
…indows-registry' into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
…indows-registry' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
…lementation-global-tools-windows
…lementation-global-tools-windows
…generic-get-version-implementation-global-tools-windows # Conflicts: # CHANGELOG.adoc
…generic-get-version-implementation-global-tools-windows # Conflicts: # CHANGELOG.adoc
…lementation-global-tools-windows # Conflicts: # CHANGELOG.adoc
…y installation info
Collaborator
Coverage Report for CI Build 30883639185Coverage increased (+0.01%) to 72.6%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions40 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
vivu001
changed the title
vivu001
added
windows
…lementation-global-tools-windows
7 tasks
Contributor
|
The PR correctly implements getInstalledVersion using the WindowsHelper interface. However, it looks like there are some merge conflicts, so I would move this to Reviews once those have been resolved |
…lementation-global-tools-windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1870
This PR is a renewal of the previous PR #1896.
Implemented changes:
getInstalledVersion()ofGlobalToolCommandletto look up tool in Windows registry.getWindowsRegistryAppName()inDockerandPgAdminso Windows registry lookup uses the correct app names.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal