#1870: Add generic get-version implementation for global tools under windows

CHANGELOG.adoc

@@ -6,6 +6,7 @@ This file documents all notable changes to https://github.com/devonfw/IDEasy[IDE
 
 Release with new features and bugfixes:
 
+* https://github.com/devonfw/IDEasy/issues/1870[#1870]: Add generic get-version implementation for global tools under windows
 * https://github.com/devonfw/IDEasy/issues/2187[#2187]: Start SoapUI commandlet in background
 * https://github.com/devonfw/IDEasy/issues/2189[#2189]: Integrate Ruff
 * https://github.com/devonfw/IDEasy/issues/2126[#2126]: Fix language selection dropdown

cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java

@@ -14,6 +14,8 @@
 import com.devonfw.tools.ide.context.IdeContext;
 import com.devonfw.tools.ide.io.FileAccess;
 import com.devonfw.tools.ide.log.IdeLogLevel;
+import com.devonfw.tools.ide.os.WindowsAppInstallation;
+import com.devonfw.tools.ide.os.WindowsHelper;
 import com.devonfw.tools.ide.process.ProcessContext;
 import com.devonfw.tools.ide.process.ProcessErrorHandling;
 import com.devonfw.tools.ide.process.ProcessMode;
@@ -187,9 +189,23 @@ protected List<PackageManagerCommand> getInstallPackageManagerCommands() {
     return List.of();
   }
 
+  /**
+   * @return the app name to look for in the Windows registry
+   */
+  public String getWindowsRegistryAppName() {
+
+    return this.tool;
+  }
+
   @Override
   public VersionIdentifier getInstalledVersion() {
-    //TODO: handle "get-version <globaltool>"
+
+    if (this.context.getSystemInfo().isWindows()) {
+      WindowsAppInstallation installation = WindowsHelper.get(this.context).getAppInstallationFromRegistry(getWindowsRegistryAppName());
+      if (installation != null) {
+        return VersionIdentifier.of(installation.version());
+      }
+    }
     return null;
   }
 

cli/src/main/java/com/devonfw/tools/ide/tool/docker/Docker.java

@@ -184,4 +184,9 @@ public String getToolHelpArguments() {
 
     return "help";
   }
+
+  @Override
+  public String getWindowsRegistryAppName() {
+    return "Docker Desktop";
+  }
 }

cli/src/main/java/com/devonfw/tools/ide/tool/pgadmin/PgAdmin.java

@@ -102,4 +102,9 @@ private Path getExecutableFolderFromWindowsRegistry() {
     }
     return null;
   }
+
+  @Override
+  public String getWindowsRegistryAppName() {
+    return "pgAdmin 4v9_is1";
+  }
 }

cli/src/test/java/com/devonfw/tools/ide/tool/GlobalToolCommandletTest.java

@@ -10,10 +10,10 @@
 import com.devonfw.tools.ide.context.IdeContext;
 import com.devonfw.tools.ide.context.IdeTestContext;
 import com.devonfw.tools.ide.os.SystemInfoMock;
+import com.devonfw.tools.ide.os.WindowsAppInstallation;
+import com.devonfw.tools.ide.os.WindowsHelperMock;
 import com.devonfw.tools.ide.process.ProcessResult;
 import com.devonfw.tools.ide.version.VersionIdentifier;
-import com.devonfw.tools.ide.tool.ToolEdition;
-import com.devonfw.tools.ide.tool.ToolEditionAndVersion;
 
 /**
  * Test of {@link GlobalToolCommandlet}.
@@ -25,8 +25,8 @@ class GlobalToolCommandletTest extends AbstractIdeContextTest {
   private static final String TOOL_VERSION = "1.21.0";
 
   /**
-   * Dummy {@link GlobalToolCommandlet} that simulates a background GUI installer (e.g. Rancher Desktop on Windows).
-   * Only {@code doInstall} is overridden so the warning-check inside the real {@code install()} is exercised.
+   * Dummy {@link GlobalToolCommandlet} that simulates a background GUI installer (e.g. Rancher Desktop on Windows). Only {@code doInstall} is overridden so the
+   * warning-check inside the real {@code install()} is exercised.
    */
   static class AsyncInstallerToolCommandlet extends GlobalToolCommandlet {
 
@@ -97,4 +97,50 @@ void testInstallDirectlyAlsoLogsWarningWhenInstallationIsAsynchronous() {
     assertThat(context).logAtWarning()
         .hasMessageContaining("rerun your 'ide' command in a new terminal session after the installation has completed.");
   }
+
+  /**
+   * Tests that the default Windows registry app name is the tool name.
+   */
+  @Test
+  void testGetWindowsRegistryAppName() {
+
+    // arrange
+    IdeTestContext context = newContext(PROJECT_BASIC);
+    AsyncInstallerToolCommandlet commandlet = new AsyncInstallerToolCommandlet(context);
+
+    // act + assert
+    assertThat(commandlet.getWindowsRegistryAppName()).isEqualTo(TOOL_NAME);
+  }
+
+  /**
+   * Tests that {@link GlobalToolCommandlet#getInstalledVersion()} reads the version from the Windows registry.
+   */
+  @Test
+  void testGetInstalledVersionReadsVersionFromWindowsRegistry() {
+
+    // arrange
+    IdeTestContext context = newContext(PROJECT_BASIC);
+    context.setSystemInfo(SystemInfoMock.WINDOWS_X64);
+    WindowsHelperMock helper = (WindowsHelperMock) context.getWindowsHelper();
+    helper.setAppInstallationFromRegistry(TOOL_NAME, new WindowsAppInstallation("2.3.4", null, null, null));
+    AsyncInstallerToolCommandlet commandlet = new AsyncInstallerToolCommandlet(context);
+
+    // act + assert
+    assertThat(commandlet.getInstalledVersion()).isEqualTo(VersionIdentifier.of("2.3.4"));
+  }
+
+  /**
+   * Tests that {@link GlobalToolCommandlet#getInstalledVersion()} returns {@code null} when no registry entry exists.
+   */
+  @Test
+  void testGetInstalledVersionReturnsNullWhenRegistryEntryIsMissing() {
+
+    // arrange
+    IdeTestContext context = newContext(PROJECT_BASIC);
+    context.setSystemInfo(SystemInfoMock.WINDOWS_X64);
+    AsyncInstallerToolCommandlet commandlet = new AsyncInstallerToolCommandlet(context);
+
+    // act + assert
+    assertThat(commandlet.getInstalledVersion()).isNull();
+  }
 }