Skip to content

#2382: Hotfix for DotNetTest - #2383

Merged
hohwille merged 2 commits into
devonfw:mainfrom
samuelkos17:feature/2382-testSetEnvironment-in-DotNetTest-failing-on-windows
Aug 27, 2026
Merged

#2382: Hotfix for DotNetTest#2383
hohwille merged 2 commits into
devonfw:mainfrom
samuelkos17:feature/2382-testSetEnvironment-in-DotNetTest-failing-on-windows

Conversation

@samuelkos17

@samuelkos17 samuelkos17 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2382

Implemented changes:

  • Changed the testSetEnvironment()-test to work on Windows (The problem was that the environment context was hardcoded to have a MSYS path but the expectedPath remained as a normal Windows Path)

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Aug 27, 2026
@samuelkos17 samuelkos17 self-assigned this Aug 27, 2026
@samuelkos17 samuelkos17 moved this from 🆕 New to 👀 In review in IDEasy board Aug 27, 2026
@samuelkos17 samuelkos17 added test related to testing and QA dotnet .NET SDK for C# and more bugfix PR that fixes a bug issue labels Aug 27, 2026
@coveralls

coveralls commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 33061737274

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.004%) to 73.729%

Details

  • Coverage increased (+0.004%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 18221
Covered Lines: 14038
Line Coverage: 77.04%
Relevant Branches: 8074
Covered Branches: 5349
Branch Coverage: 66.25%
Branches in Coverage %: Yes
Coverage Strength: 3.29 hits per line

💛 - Coveralls

@hohwille hohwille added this to the release:2026.08.002 milestone Aug 27, 2026
Comment thread CHANGELOG.adoc Outdated

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelkos17 thanks for your fast fix of this problem. 👍
Maybe we can have a internal meeting where we create more awareness in the team to prevent such problems in the future. It is already part of our documentation but not every developer can have all our documentation in his head.

@hohwille
hohwille merged commit dc507df into devonfw:main Aug 27, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Aug 27, 2026
@samuelkos17

Copy link
Copy Markdown
Contributor Author

Successfully tested on current main branch on Windows.

@samuelkos17 samuelkos17 added the QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue dotnet .NET SDK for C# and more QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. test related to testing and QA

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Hotfix: testSetEnvironment() in DotNetTest.java failing on windows

3 participants