Skip to content
This repository was archived by the owner on Jul 21, 2019. It is now read-only.

Adding vimeo as an option#543

Merged
mattstratton merged 1 commit into
masterfrom
add-vimeo
May 30, 2017
Merged

Adding vimeo as an option#543
mattstratton merged 1 commit into
masterfrom
add-vimeo

Conversation

@bridgetkromhout

Copy link
Copy Markdown
Contributor

As reported in #542 it appears we didn't have code in the talk page to handle displaying vimeo. I've copied the youtube code and modified it to work with vimeo. In local testing this makes vimeo show up correctly.

screen shot 2017-05-28 at 5 04 09 pm

This will need to be merged and released before devopsdays/devopsdays-web#2471 works correctly.

Fixes #542

@mattstratton

Copy link
Copy Markdown
Member

Before merging, I need to see if there are any docs that also need updating (reference.md, etc).

I'll review later tonight if possible.

@Roderick-Jonsson

Copy link
Copy Markdown

My heroes :)

@bridgetkromhout

Copy link
Copy Markdown
Contributor Author

It looks like this currently is the only item at its indent level:
## Fields in YYYY-CITY.yml

@mattstratton does this mean that you intend the reference.md file to later also talk about frontmatter from other file choices such as a talk file? It's unclear to me where we currently want to explain the talk file frontmatter.

@mattstratton

Copy link
Copy Markdown
Member

Yeah, I guess I never finished that part :)

@mattstratton

Copy link
Copy Markdown
Member

Basically, reference.md should be considered canonical for every field/"api" type thing in the theme. I just haven't gotten to that level yet.

@mattstratton

Copy link
Copy Markdown
Member

I'm good with merging this. I'll add in another PR for this release to include talk page frontmatter in the docs, since we need that anyway.

@mattstratton
mattstratton merged commit 9a388e3 into master May 30, 2017
@mattstratton
mattstratton deleted the add-vimeo branch June 28, 2017 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants