chore: use a dedicated RBE cluster for release builds - #11046
Draft
basvandijk wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the RBE evaluation GitHub Actions workflow to ensure release builds use a dedicated Namespace RBE cluster (selected via a secret --key) instead of sharing the same cluster as PR builds, reducing cache poisoning risk.
Changes:
- Select the
release-remote-build-execution-clusterGitHub Environment whenrelease-build == 'true'. - Update the RBE setup step to conditionally pass
--key=$SECRET_RBE_CLUSTER_KEYfor release builds and hard-fail if the key is missing (to avoid silently falling back to the shared cluster).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
172
to
+174
| needs: [config, infer-bazel-targets] | ||
| environment: | ||
| name: ${{ case(needs.config.outputs.release-build == 'true', 'release-remote-build-execution-cluster', '') }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See slack thread.
To reduce cache poisoning attacks we would like release builds to be executed on a different RBE cluster than the one used for PRs. This is accomplished by configuring
nsc bazel execution setupwith a--key=<SECRET_RBE_CLUSTER_KEY>documented as:secrets.SECRET_RBE_CLUSTER_KEYis only provided by the GitHub environmentrelease-remote-build-execution-clusterwhich is only accessible on the protected branches:hotfix-*,masterandrc--*which only a selected number of authorised users can push to.There's one current issue:
public-hotfix-*branches setrelease-buildtotruebut they are not protected in the same way as the before mentioned branches, i.e. anybody with Write access can push to them. This means that the RBE job will fail on them. I'll probably fix this by not settingrelease-buildtotrueforpublic-hotfix-*branches. I don't think they need it. But I need to confirm with the relevant engineers. See: #11047.