chore: don't run CI on public-hotfix branches - #11047
Merged
Merged
Conversation
nmattia
approved these changes
Aug 6, 2026
pietrodimarco-dfinity
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a hotfix lands on a
public-hotfix-*branch it has already been build, released and deployed so it doesn't have to be build and released again.It's also the case that
public-hotfix-*branches are not protected in the same way asmaster,rc--*andhotfix-*, i.e. any user with Write access to the repo can push to them.We would like to make branches that build releases more secure. The end goal is that builds on those branches will run on a cluster separate from the one used for PRs to reduce the risk of cache poisoning attacks.
public-hotfix-*branches currently trigger a release build which conflicts with this.So this commit simply removes any
public-hotfix-*trigger from our CI logic so it's treated like a normal feature branch. Note that the GitHub branch protection forpublic-hotfix-*remains in place.