refactor(cketh): rename EthTransactions to WithdrawalTransactions and hide its fields

[gregorydemay]

Part of DEFI-2917 (deposit-from-CEX), the first of a stack preparing the minter to send Ethereum transactions from a second address. Pure refactoring: no behaviour change, and no test loses or gains coverage.

Wide but shallow — a rename across twelve files plus one genuine change. The substantive work sits in the PRs above.

What

• Renames EthTransactions to WithdrawalTransactions. The name has to give way: a second sender address is coming, and its transactions are equally "Eth transactions". What distinguishes this one is that it carries user withdrawals.
• Makes the fields private. No production code ever read one — the visibility existed solely so state::tests could assemble a populated value and vary one field at a time to exercise is_equivalent_to. A builder in transactions::tests covers that without exposing the fields. It does nothing but collect them, so what a test builds is still spelled out at the test; and since varying a field is what the test is for, each case clones the builder and changes only the field it is probing rather than restating the other eight:

withdrawal_transactions: builder.clone().with_sent_tx(Default::default()).build(),

state_equivalence keeps every assertion it had, in place.

Note on visibility

transactions::tests is pub(in crate::state) so state::tests can name the builder. A plain associated function would not need that — method resolution does not go through the module path — but a builder is a type, and types need a reachable path. The fields themselves stay private, which is the point of the change.

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[Copilot]

Pull request overview

Refactors the ckETH minter’s Ethereum transaction tracking by separating “send/nonce state machine” concerns from withdrawal reimbursement bookkeeping, preparing the codebase for supporting multiple independent transaction lanes (e.g., a sweeper address) without inheriting refund logic.

Changes:

• Split the original EthTransactions into a private TransactionLane (send machinery) plus a new EthTransactions wrapper that owns a lane and reimbursement state, forwarding the lane API to keep callers stable.
• Centralized the “arm reimbursement on create / disarm on finalize” invariant in the wrapper (record_created_transaction / record_finalized_transaction).
• Moved state-equivalence fixture logic into the transactions test module and adjusted tests to account for the new lane encapsulation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
rs/ethereum/cketh/minter/src/state/transactions/mod.rs	Introduces TransactionLane and reworks EthTransactions into a wrapper that couples lane finalization with reimbursement tracking.
rs/ethereum/cketh/minter/src/state/transactions/tests.rs	Updates unit tests for the new lane field and adds a shared fixture for state-equivalence tests.
rs/ethereum/cketh/minter/src/state/tests.rs	Switches state-equivalence test setup to reuse the fixture now hosted under state::transactions::tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 8d4bc99.

Security Overview

• 🔎 Scanned files: 12 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/783a9bd4-fb4e-4e10-ab3c-c2fb2ddfb92f?scanId=cd987add-f7e7-4333-ba8d-ba8b5f8d2588&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type

Relevant files

Refactor

► rs/ethereum/cketh/minter/src/dashboard.rs      Switch from eth_transactions to withdrawal_transactions in various dashboards and status lookups ► rs/ethereum/cketh/minter/src/guard/mod.rs      Update pending_requests_count to use withdrawal_transactions ► rs/ethereum/cketh/minter/src/guard/tests.rs      Adjust tests to reference withdrawal_transactions ► rs/ethereum/cketh/minter/src/lifecycle/init.rs      Replace EthTransactions with WithdrawalTransactions in state initialization ► rs/ethereum/cketh/minter/src/lifecycle/tests.rs      Update tests to use WithdrawalTransactions for nonce checks ► rs/ethereum/cketh/minter/src/main.rs      Replace eth_transactions with withdrawal_transactions in status and time calculations ► rs/ethereum/cketh/minter/src/state.rs      Rename EthTransactions to WithdrawalTransactions; replace all references accordingly ► rs/ethereum/cketh/minter/src/state/audit.rs      Refactor to use withdrawal_transactions in state transitions ► rs/ethereum/cketh/minter/src/state/transactions/mod.rs      Rename module from EthTransactions to WithdrawalTransactions and export path changes ► rs/ethereum/cketh/minter/src/state/transactions/tests.rs      Update tests to instantiate WithdrawalTransactions and reference WithdrawalTransactions in imports ► rs/ethereum/cketh/minter/src/state/tests.rs      Update state/tests to use WithdrawalTransactions builder and related fields ► rs/ethereum/cketh/minter/src/state/transactions/tests.rs      Update tests to refer to WithdrawalTransactions and adjust types accordingly