feat(scripts): DLT-3033 DLT-3034 DLT-3035 add link-rendering migration codemod and ESLint rule

[Francis Rupert (francisrupert)]

🛠️ Type Of Change

• Feature

📖 Jira Tickets

• DLT-3033: DtButton anchor / router-link migration
• DLT-3034: DtLink anchor / router-link migration
• DLT-3035: DtLink underline prop migration
• Epic: DLT-2980 Q1 26 Dialtone Next Migration Toolkit

📖 Description

New CLI: npx dialtone-migrate-link-rendering. Walks Vue files. Rewrites three legacy patterns:

1. <a class="d-btn"> / <router-link class="d-btn"> -> <dt-button href|to> (DLT-3033)
2. <a class="d-link"> / <router-link class="d-link"> -> <dt-link href|to> (DLT-3034)
3. <dt-link class="d-td-..."> -> <dt-link :underline="..."> (DLT-3035)

Also extracts d-btn--* and d-link--* modifier classes into matching props (size, kind, importance, tone), with the same value renames dialtone-migrate-props does (danger -> critical, success -> positive).

Plus:

• ESLint rule dialtone/deprecated-link-styling-classes (detection only, opt-in via 'warn')
• What's-new blog post (2026-4-30.md)
• .claude/rules/link-and-button-navigation.md for IDE / Claude authoring guidance
• dt-migrate skill table updated with the new entry

💡 Context

PRs #1055 and #1056 added to / href props on DtButton and DtLink, and #1059 added the underline prop. Consumer codebases still carry the old workaround patterns. This is the migration tooling.

Vue files only by default. --include-markdown opts into .md files for projects with VuePress documentation.

What this PR does NOT do

• No autofixer on the ESLint rule. Detection only.
• No migration of consumer product code. The CLI is the deliverable; product teams run it themselves.
• No DtSplitButton anchor / router-link support (called out as future work in PR feat(button): DLT-3009 add support for anchor and router-link rendering #1055).

📦 Cross-Package Impact

Package	Changes
dialtone-css	New CLI dialtone-migrate-link-rendering
eslint-plugin-dialtone	New rule deprecated-link-styling-classes
dialtone-documentation	New what's-new blog post
(claude config)	New .claude/rules/ entry, dt-migrate skill update

📝 Checklist

For all PRs:

• No private Dialpad links or info in the code or PR description.
• Changes reviewed.
• Documentation added (what's-new blog post, ESLint rule doc page, Claude rule).
• Performance considered (fast-path early-exit on files with no relevant tokens, memoized regexes for the four (sourceTag, requiredClass) combinations).

🔗 Sources

• Original feature PRs: feat(button): DLT-3009 add support for anchor and router-link rendering #1055 (DLT-3009), feat(link): DLT-3010 add router-link rendering support #1056 (DLT-3010), feat(link,button): DLT-3012 add underline prop #1059 (DLT-3012)
• Sibling codemod precedent: dialtone-migrate-props (PR feat(scripts): DLT-3304 add scripts/docs for migration props changes #1219)

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Adds a new standalone codemod CLI (dialtone-migrate-link-rendering) and transform engine (button-nav, link-nav, underline), test fixtures and suites, test helpers, an ESLint rule plus docs, a migration blog post, and package bin entries exposing the CLI.

Changes

Cohort / File(s)	Summary
Migration CLI & Engine packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs, package.json, packages/dialtone-css/package.json	New executable CLI and exported transformContent(content, opts?) implementing masking, three transform passes (button-nav, link-nav, underline), warning/note aggregation, file scanning, flags (--only, --dry-run, --cwd, --yes) and write prompts; package bin entries updated to expose the CLI.
Button-nav Tests & Fixtures packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/button-nav.test.mjs, .../button-nav-test-examples.vue	Test suite and Vue fixture covering conversion of d-btn anchors/router-links to <dt-button> with attribute lifting, modifier→prop mappings, boolean flags, preservation of unrelated attrs/classes, idempotency, and skip/warn cases for dynamic/responsive/wrapper patterns.
Link-nav Tests & Fixtures packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/link-nav.test.mjs, .../link-nav-test-examples.vue	Tests and fixture for converting d-link to <dt-link>: href/to lifting, tone extraction/renames, d-link--no-underline → :underline="false", inverted handling notes, class preservation, and unsupported-pattern warnings.
Underline Tests & Fixtures packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/underline.test.mjs, .../underline-test-examples.vue	Tests and fixture for extracting d-td-*/h:d-td-* into :underline prop where applicable, emitting hover-delta notes, skipping responsive/dynamic cases, and ensuring idempotency.
Test Helpers packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/helpers.mjs	Adds runTransform(input, opts) and runTransformVerbose(input, opts) helpers that invoke transformContent for tests.
ESLint Rule, Tests & Docs packages/eslint-plugin-dialtone/lib/rules/deprecated-link-styling-classes.js, packages/eslint-plugin-dialtone/tests/lib/rules/deprecated-link-styling-classes.js, packages/eslint-plugin-dialtone/docs/rules/deprecated-link-styling-classes.md	New ESLint rule detecting a/router-link with d-btn/d-link and dt-link with d-td-* utilities; rule implementation, tests covering valid/invalid cases (including PascalCase tags) and documentation with examples and migration guidance.
Migration UX Docs & Blog Post .claude/rules/link-and-button-navigation.md, .claude/skills/dt-migrate.md, apps/dialtone-documentation/docs/dialtone/whats-new/posts/2026-4-30.md	Adds migration guidance, CLI invocation notes (including npx dialtone-migrate-link-rendering), rendering semantics (use to vs href, underline prop), example snippets, migration caveats and ESLint integration.
Pkg bin mappings (lib/dist) packages/dialtone-css/package.json, package.json	Updated top-level and package bin mappings to include dialtone-migrate-link-rendering pointing to the built ESM entry; minor formatting adjustments to existing bin lines.

Sequence Diagram

sequenceDiagram
    participant User
    participant CLI as "CLI Tool\n(dialtone-migrate-link-rendering)"
    participant FS as "File System"
    participant Engine as "Transform Engine\n(transformContent)"

    User->>CLI: run command (args)
    CLI->>FS: scan files (by globs / --cwd)
    FS-->>CLI: file list & contents
    CLI->>Engine: transformContent(fileContent, opts)
    activate Engine
    Engine->>Engine: mask inert regions (comments, scripts, styles, code blocks)
    Engine->>Engine: pass: button-nav (d-btn → <dt-button>)
    Engine->>Engine: pass: link-nav (d-link → <dt-link>, tone/underline mapping)
    Engine->>Engine: pass: underline (d-td-* → :underline)
    Engine->>Engine: collect warnings & notes
    Engine-->>CLI: { transformed, warnings, notes }
    deactivate Engine
    CLI->>User: show summary, warnings, changed files
    alt not --dry-run and not --yes
        CLI->>User: prompt to write
        User->>CLI: confirm
    end
    CLI->>FS: write files (if confirmed)
    FS-->>User: files updated

Loading

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/DLT-3033-link-rendering-migration

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 313f759f52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

[coderabbitai]

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs`:
- Line 60: Update FAST_PATH_RE and the tag-matching logic so PascalCase
component names are recognized: change the constant FAST_PATH_RE (currently
/d-btn|d-link|d-td-|<router-link/) to match both lowercase and PascalCase
variants (e.g. include RouterLink and DtLink variants or use a case-insensitive
pattern). In the functions transformButtonNav, transformLinkNav,
transformUnderline and warnRouterLinkCustomWrappers replace hardcoded tag checks
for "<router-link>" and "<dt-link>" with a regex/logic that matches both
"<router-link>" and "<RouterLink>" (and "dt-link"/"DtLink" or
"d-link"/"D-Link"/Dt variants used in this codebase), and ensure transformation
regexes that target tag names are updated the same way; finally add regression
tests that include PascalCase SFC examples for RouterLink and DtLink to verify
migration and warnings.

In
`@packages/eslint-plugin-dialtone/docs/rules/deprecated-link-styling-classes.md`:
- Line 7: Update the documentation in
packages/eslint-plugin-dialtone/docs/rules/deprecated-link-styling-classes.md to
clarify that the codemod npx dialtone-migrate-link-rendering performs a
best-effort migration and will skip or warn on dynamic/unsupported patterns (for
example dynamic bindings, conditional templates, or unsupported variants), so
migration may be partial and require manual fixes; add a concise sentence after
the existing paragraph that explicitly lists these example cases and notes the
codemod will emit warnings when it cannot safely transform a pattern.

In
`@packages/eslint-plugin-dialtone/lib/rules/deprecated-link-styling-classes.js`:
- Around line 71-74: In create(context) the code calls
sourceCode.parserServices.defineTemplateBodyVisitor which will crash when
parserServices or defineTemplateBodyVisitor is undefined (non-vue parsers);
update the guard so that after obtaining sourceCode you check for
sourceCode.parserServices and typeof
sourceCode.parserServices.defineTemplateBodyVisitor === 'function' and if absent
return {} (a no-op visitor); this prevents errors when the rule runs outside
vue-eslint-parser while keeping the existing behavior when
defineTemplateBodyVisitor is present.
- Around line 76-78: The tag normalization currently uses rawName.toLowerCase()
which turns PascalCase Vue components like RouterLink into routerlink and misses
kebab-case matches; change the normalization used in this rule (referencing
node.rawName / node.name and the tagName variable) to the same kebab-case
normalization used in deprecated-physical-naming.js (either call its toKebabCase
helper or extract a shared toKebabCase and reuse it) before checking
RELEVANT_TAGS so PascalCase and kebab-case Vue tags both match correctly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: fa1b82c7-551d-4717-a016-d7f9473c55f3

📥 Commits

Reviewing files that changed from the base of the PR and between 961965a and 313f759.

📒 Files selected for processing (16)

• .claude/rules/link-and-button-navigation.md
• .claude/skills/dt-migrate.md
• apps/dialtone-documentation/docs/dialtone/whats-new/posts/2026-4-30.md
• package.json
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/button-nav-test-examples.vue
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/button-nav.test.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/helpers.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/link-nav-test-examples.vue
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/link-nav.test.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/underline-test-examples.vue
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/underline.test.mjs
• packages/dialtone-css/package.json
• packages/eslint-plugin-dialtone/docs/rules/deprecated-link-styling-classes.md
• packages/eslint-plugin-dialtone/lib/rules/deprecated-link-styling-classes.js
• packages/eslint-plugin-dialtone/tests/lib/rules/deprecated-link-styling-classes.js

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs`:
- Around line 629-635: The regex in transformUnderline currently matches
self-closing tags; update the pattern so it skips tags that end with '/>'
(self-closing). Specifically, in the new RegExp call that builds
`<(${tagNamePattern('dt-link')})\\b(${QUOTE_AWARE_ATTRS}?)>`, add a negative
lookahead to prevent matching a trailing slash before the closing angle bracket
(for example change the end to `(?!\\s*/>)>` or use `(?![^>]*\/>)>`), so
transformUnderline only matches opening dt-link tags (not `<dt-link ... />`)
while keeping references to tagNamePattern and QUOTE_AWARE_ATTRS intact.
- Around line 641-655: The code only inspects dynamic :class when no static
class is found, so mixed cases are missed; modify the logic around
classMatch/dynClassMatch in index.mjs to always check for a dynamic binding (the
dynClassMatch regex and extraction of expr) even if classMatch exists, and if
the dynamic expr contains /d-td-/ push the same ctx.warnings entry used
currently; ensure this check runs before returning fullTag (and keep the
existing static-class handling intact) so examples like <dt-link class="foo"
:class="{ 'd-td-none': off }"> trigger the manual-review warning.
- Around line 410-413: The current regex assigned to `cached` (involving
`tagNamePattern`, `QUOTE_AWARE_ATTRS`, `escapeRe`, and `requiredClass`) uses
`\b` which incorrectly matches modifier-only tokens like `d-btn--lg`; update the
pattern so the class attribute match requires the exact token (e.g., ensure the
requiredClass is bounded by either string start/space before and space/string
end after) rather than `\b`, i.e. modify the portion that searches inside the
class value to look for `(?:^|\s)${escapeRe(requiredClass)}(?:\s|$)` (and adjust
any capturing groups used later accordingly) so only elements with the actual
`d-btn`/`d-link` token are rewritten.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: bdf4a537-2545-4977-adc7-d9c3a59ea31a

📥 Commits

Reviewing files that changed from the base of the PR and between e4bcdbd and 521553d.

📒 Files selected for processing (7)

• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/button-nav.test.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/link-nav.test.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/underline.test.mjs
• packages/eslint-plugin-dialtone/docs/rules/deprecated-link-styling-classes.md
• packages/eslint-plugin-dialtone/lib/rules/deprecated-link-styling-classes.js
• packages/eslint-plugin-dialtone/tests/lib/rules/deprecated-link-styling-classes.js

[coderabbitai]

♻️ Duplicate comments (3)

packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs (3)

644-657: ⚠️ Potential issue | 🟠 Major

Mixed static + dynamic :class silently skips dynamic warning.

When both class="d-td-none" and :class="{ 'd-td-underline': on }" are present, the dynamic check at line 647 never runs because classMatch succeeds. Partial migration proceeds without the manual-review warning.

,

Check dynamic :class unconditionally

+    // Always check for dynamic :class containing d-td-* — warn even if static class exists
+    const dynClassMatch = attrs.match(/(?:^|\s)(?::|v-bind:)class=("([^"]*)"|'([^']*)')/);
+    if (dynClassMatch) {
+      const expr = dynClassMatch[2] !== undefined ? dynClassMatch[2] : dynClassMatch[3];
+      if (/d-td-/.test(expr)) {
+        ctx.warnings.push(
+          `${ctx.filePath}: <dt-link :class="${expr}"> contains d-td-* in a dynamic binding — manual review required.`,
+        );
+        return fullTag;
+      }
+    }
+
     const classMatch = attrs.match(/(?<![:\w-])class=("([^"]*)"|'([^']*)')/);
     if (!classMatch) {
-      // No static class. Check if there's a dynamic :class with d-td-* in it — warn.
-      const dynClassMatch = attrs.match(/(?:^|\s)(?::|v-bind:)class=("([^"]*)"|'([^']*)')/);
-      if (dynClassMatch) {
-        const expr = dynClassMatch[2] !== undefined ? dynClassMatch[2] : dynClassMatch[3];
-        if (/d-td-/.test(expr)) {
-          ctx.warnings.push(
-            `${ctx.filePath}: <dt-link :class="${expr}"> contains d-td-* in a dynamic binding — manual review required.`,
-          );
-        }
-      }
       return fullTag;
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs`
around lines 644 - 657, The current logic returns early when classMatch exists
and therefore never inspects a dynamic :class; change the flow in the block that
inspects attrs so that the dynamic binding check using dynClassMatch =
attrs.match(/(?:^|\s)(?::|v-bind:)class=("([^"]*)"|'([^']*)')/) runs
unconditionally (or at least also when classMatch is truthy) before returning
fullTag, and if dynClassMatch contains an expression with /d-td-/ push the same
ctx.warnings message using ctx.filePath and the extracted expr; ensure you still
preserve the existing static-class behavior (keep using classMatch to handle
static classes) but do not skip the dynamic-binding warning when both static and
dynamic class attributes are present.

---

636-638: ⚠️ Potential issue | 🔴 Critical

Self-closing <dt-link /> tags get malformed by underline transform.

The pattern <dt-link\b(QUOTE_AWARE_ATTRS?)> matches self-closing tags because / is captured by [^>]* in QUOTE_AWARE_ATTRS, then the trailing > matches. Result: <dt-link class="d-td-none" /> → <dt-link :underline="false"> (broken markup).

,

Capture and skip self-closing

-  const re = new RegExp(`<(${tagNamePattern('dt-link')})\\b(${QUOTE_AWARE_ATTRS}?)>`, 'g');
-  return content.replace(re, (fullTag, matchedTagName, rawAttrs) => {
+  const re = new RegExp(`<(${tagNamePattern('dt-link')})\\b(${QUOTE_AWARE_ATTRS}?)(/?)>`, 'g');
+  return content.replace(re, (fullTag, matchedTagName, rawAttrs, selfClose) => {
+    if (selfClose === '/') return fullTag;
     const attrs = rawAttrs || '';

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs`
around lines 636 - 638, The regex match and replacement for dt-link currently
transforms self-closing tags because QUOTE_AWARE_ATTRS captures the trailing
slash; fix by detecting and skipping self-closing tags in the replace callback:
in the replacement function for the regex built with tagNamePattern('dt-link')
and QUOTE_AWARE_ATTRS, check if rawAttrs/attrs endsWith('/') or if fullTag
endsWith('/>') (trim whitespace) and if so return fullTag unchanged; otherwise
proceed to build attrs and replace with :underline="false" as before.

---

410-416: ⚠️ Potential issue | 🟠 Major

\b word boundaries match modifier-only classes as false positives.

The regex pattern uses \b${escapeRe(requiredClass)}\b which matches d-btn inside d-btn--lg (word boundary exists at n→-). Elements with only d-btn--lg but no base d-btn class get rewritten incorrectly. The ESLint rule uses exact token matching (tokens.includes('d-btn')); the codemod should match.

,

Suggested guard after class extraction

   while ((m = openWithClassRe.exec(content)) !== null) {
     const [fullOpen, attrsBefore, , quotedDouble, quotedSingle, attrsAfter, selfClose] = m;
     const classValue = quotedDouble !== undefined ? quotedDouble : quotedSingle;
+    if (!splitClasses(classValue).includes(config.baseClass)) continue;
     const openStart = m.index;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs`
around lines 410 - 416, The regex uses word boundaries
(\b${escapeRe(requiredClass)}\b) which falsely matches modifier-only classes
like d-btn--lg; update the class-token match inside the cached RegExp (the one
created before OPEN_WITH_CLASS_RE_CACHE.set(key, cached)) to require whole-class
tokens instead of \b boundaries by replacing the \b... \b pattern with explicit
class-token anchors such as (?:^|\s)${escapeRe(requiredClass)}(?:\s|$) (i.e.
ensure the requiredClass is preceded by start or whitespace and followed by
whitespace or end) so the generated regex only matches exact class tokens inside
the captured class attribute; keep the rest of the pattern (QUOTE_AWARE_ATTRS,
tagNamePattern(sourceTag), escapeRe, and the caching via
OPEN_WITH_CLASS_RE_CACHE) unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In
`@packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs`:
- Around line 644-657: The current logic returns early when classMatch exists
and therefore never inspects a dynamic :class; change the flow in the block that
inspects attrs so that the dynamic binding check using dynClassMatch =
attrs.match(/(?:^|\s)(?::|v-bind:)class=("([^"]*)"|'([^']*)')/) runs
unconditionally (or at least also when classMatch is truthy) before returning
fullTag, and if dynClassMatch contains an expression with /d-td-/ push the same
ctx.warnings message using ctx.filePath and the extracted expr; ensure you still
preserve the existing static-class behavior (keep using classMatch to handle
static classes) but do not skip the dynamic-binding warning when both static and
dynamic class attributes are present.
- Around line 636-638: The regex match and replacement for dt-link currently
transforms self-closing tags because QUOTE_AWARE_ATTRS captures the trailing
slash; fix by detecting and skipping self-closing tags in the replace callback:
in the replacement function for the regex built with tagNamePattern('dt-link')
and QUOTE_AWARE_ATTRS, check if rawAttrs/attrs endsWith('/') or if fullTag
endsWith('/>') (trim whitespace) and if so return fullTag unchanged; otherwise
proceed to build attrs and replace with :underline="false" as before.
- Around line 410-416: The regex uses word boundaries
(\b${escapeRe(requiredClass)}\b) which falsely matches modifier-only classes
like d-btn--lg; update the class-token match inside the cached RegExp (the one
created before OPEN_WITH_CLASS_RE_CACHE.set(key, cached)) to require whole-class
tokens instead of \b boundaries by replacing the \b... \b pattern with explicit
class-token anchors such as (?:^|\s)${escapeRe(requiredClass)}(?:\s|$) (i.e.
ensure the requiredClass is preceded by start or whitespace and followed by
whitespace or end) so the generated regex only matches exact class tokens inside
the captured class attribute; keep the rest of the pattern (QUOTE_AWARE_ATTRS,
tagNamePattern(sourceTag), escapeRe, and the caching via
OPEN_WITH_CLASS_RE_CACHE) unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 225652ad-4add-4fa2-8f51-6c0cba00d5ba

📥 Commits

Reviewing files that changed from the base of the PR and between 521553d and 6031ebf.

📒 Files selected for processing (4)

• apps/dialtone-documentation/docs/dialtone/whats-new/posts/2026-4-30.md
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/button-nav.test.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/link-nav.test.mjs

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs`:
- Around line 582-595: warnRouterLinkCustomWrappers currently checks for the
target tag by testing the entire remainder of the file (variable after) which
yields false positives; restrict the search to the current <router-link> body by
locating the matching closing tag and slicing only that segment before running
targetRe. Concretely: after you get m from openRe, compute the remainder =
content.slice(m.index + m[0].length), find the first closing match for
`</${tagNamePattern('router-link')}>` (e.g., build a closeRe or use
remainder.indexOf('</router-link>') if safe), if no close found skip, otherwise
set body = remainder.slice(0, closeMatchEnd) and run targetRe.test(body) and
push the warning only if it matches; keep references to
warnRouterLinkCustomWrappers, openRe, targetRe, m, after and ctx.warnings in
your change.
- Around line 316-319: The normalizeAttrs function currently collapses all
whitespace including inside quoted attribute values; change it to only normalize
outer separators while preserving whitespace inside quotes/backticks by scanning
the attrs string character-by-character and tracking quote context (double
quote, single quote, backtick) so you only replace sequences of whitespace when
not inside any quote; trim leading/trailing outer separators as before and
return ` ${result}` or '' accordingly. Apply the same fix to the other
occurrences noted around the code at the blocks referenced (lines ~448 and
~711-713) where similar whitespace compaction is done.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 3f8f7d31-1979-4716-8f6c-822aa7590998

📥 Commits

Reviewing files that changed from the base of the PR and between 6031ebf and aca6041.

📒 Files selected for processing (3)

• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/button-nav.test.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/index.mjs
• packages/dialtone-css/lib/build/js/dialtone_migrate_link_rendering/underline.test.mjs

[github-actions]

✔️ Deploy previews ready!
😎 Dialtone documentation preview: https://dialtone.dialpad.com/deploy-previews/pr-1233/

[Brad Paugh (braddialpad)]

Don't have any problems with this one. As usual please integrate the blog post into the migration guide.