Skip to content

Conversation

@allredj
Copy link
Contributor

@allredj allredj commented Jul 4, 2017

Instead of naming the .out file after the file under test, we name it after the test description.
This prevents clashes when several test descriptions are present in the directory.
This should also go into master.

Addresses: diffblue/test-gen#680

Instead of naming the *.out file after the file under test, we name it
after the test description.
This prevents clashes when several test descriptions are present in the
directory.
@allredj allredj self-assigned this Jul 4, 2017
@tautschnig
Copy link
Collaborator

Instead of naming the .out file after the file under test, we name it after the test description.
This prevents clashes when several test descriptions are present in the directory.

I don't quite understand the above - it seems "test descriptions" refers to different artifacts in those two sentences?

@allredj
Copy link
Contributor Author

allredj commented Jul 4, 2017

Currently for the following configuration:

under_test.java
test1.desc
test2.desc

the created output files will both have the name under_test.out (and thus will overwrite each other).

With my suggested modification, the output files will be named: test1.out and test2.out.

@tautschnig
Copy link
Collaborator

Ah, sorry, that was me being confused. But then I do wonder whether it is a good idea to have multiple .desc descriptions in a single directory...

@allredj
Copy link
Contributor Author

allredj commented Jul 4, 2017

The script is designed to fetch all .desc files. So it shouldn't be a problem. The idea is to be able to test several command lines on the same files. This is something that we would need in test-gen. Whether someone else has made the assumption that there would be only one .desc per directory, I don't know.

In the mean time, it seems I need to fix the case were a test fails.

@tautschnig
Copy link
Collaborator

The script is designed to fetch all .desc files.

That of course is enough of a reason to apply the change you are proposing.

@allredj
Copy link
Contributor Author

allredj commented Jul 13, 2017

This PR is now replaced by #1119.

@allredj allredj closed this Jul 13, 2017
@allredj allredj deleted the regression-rename-output-files branch August 2, 2017 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants