Adapt perl script to handle multiple .desc files #1119
Conversation
allredj
requested review from
smowton and
tautschnig
and removed request for
smowton and
tautschnig
|
Is this the same as #1082, except that it's now for master? |
|
FWIW, I'm rather confused: only with #1082 in place there is a renaming according to test.desc files!? |
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
I don't think this change does what the commit message says - it actually does the opposite.
|
This replaces #1082 (which has been closed). It does the same renaming plus corrects the problem with failed tests cases. |
Can the commit message please be amended to state this, rather than claiming the converse renaming? |
|
@tautschnig I don't understand your comment. To me the commit message expresses exactly what it does. Naming the files after the |
|
Ok, maybe that's just a problem of the choice of tense: "test.pl names output *.out files after *.desc instead of *.java files" to me suggests that this is the current state, before the commit. It's not my native language, so I may be very wrong. How about "Modify test.pl to name output ..." (and then please don't refer to .java files, because these are never used as input). |
regression/failed-tests-printer.pl
Outdated
There was a problem hiding this comment.
Is this debug output? Note that the two blank lines printed next are meant to separate tests, so it may be better to place this output line further below (if it is meant to stay).
|
Commit has been amended. Debug print removed and description updated. It's hopefully clearer now. |
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
Thank you for those updates! (As a nit pick: .class are only one kind of input files that we might see.)
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
Re-approving (not sure why github requested this again).
|
@tautschnig My bad. I couldn't see your approval for some reason so I re-requested it. |
regression/failed-tests-printer.pl
Outdated
There was a problem hiding this comment.
test.desc should be replaced by the actual name of the test descriptor
There was a problem hiding this comment.
I'm not sure what you do mean by the "test descriptor". "foo.desc" will spawn "foo.out" in the same directory, "bar.desc" -> "bar.out" etc. Should I go through all repositories and rename test-name/test.desc to test-name/test-name.desc? That seems like a structural change and would require a separate ticket.
There was a problem hiding this comment.
It's about the literal use of test.desc in that print statement on line 24. Those files, after all, need not actually be named "test.desc", but could be "test1.desc" etc (your commit says "handle multiple .desc files"). Hence that print statement should say, e.g., "Failed test1.desc lines:".
There was a problem hiding this comment.
Thanks for noticing that. Fixed.
regression/failed-tests-printer.pl
Outdated
There was a problem hiding this comment.
Is that really what the output holds? I thought the output listed lines from *.desc that could not be found in $output_file?!
There was a problem hiding this comment.
How is this related to the commit?
There was a problem hiding this comment.
My apologies, multitasking issues.
Changes test.pl to name output *.out files after *.desc instead of *.class files. Also updates failed-test-printer.pl to work with those new *.out files and multiple *.desc files.
|
OK, Now it should be fine. Added additional "Descriptor" field to the tests.log file. |
5 participants
Solves the following issue: https://github.com/diffblue/test-gen/issues/680
Changes test.pl to name output *.out files after *.desc instead
of *.class files. Also updates failed-test-printer.pl to work with
those new *.out files.