Skip to content

Conversation

@allredj
Copy link
Contributor

@allredj allredj commented Jun 7, 2019

Pulls in diffblue/java-models-library#24

Prerequisite for #4760 (String.Format now uses dependency graph).

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor Author

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 132bfe0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114725937

@codecov-io
Copy link

codecov-io commented Jun 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@41f2ad6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4763   +/-   ##
==========================================
  Coverage           ?   68.45%           
==========================================
  Files              ?     1271           
  Lines              ?   104837           
  Branches           ?        0           
==========================================
  Hits               ?    71764           
  Misses             ?    33073           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f2ad6...c6ec6ac. Read the comment docs.

@allredj allredj force-pushed the update-java-models-library/PR24 branch from 132bfe0 to c6ec6ac Compare June 7, 2019 15:20
@allredj
Copy link
Contributor Author

allredj commented Jun 7, 2019

now pointing to master

Copy link
Contributor Author

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: c6ec6ac).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114763693

@smowton
Copy link
Contributor

smowton commented Jun 8, 2019

@peterschrammel has the power to override the apparent AWS outage

@allredj
Copy link
Contributor Author

allredj commented Jun 11, 2019

subsumed by #4768

@allredj allredj closed this Jun 11, 2019
@allredj allredj deleted the update-java-models-library/PR24 branch June 11, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants