Skip to content

Conversation

@peterschrammel
Copy link
Member

@peterschrammel peterschrammel commented Jun 9, 2019

Includes a required java-models-library update diffblue/java-models-library#25

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@peterschrammel peterschrammel force-pushed the add-string-format-verification-tests branch 3 times, most recently from 8493b78 to 29d4b46 Compare June 9, 2019 20:58
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 29d4b46).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114878566

@codecov-io
Copy link

codecov-io commented Jun 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@86499a6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4768   +/-   ##
==========================================
  Coverage           ?   68.58%           
==========================================
  Files              ?     1275           
  Lines              ?   105032           
  Branches           ?        0           
==========================================
  Hits               ?    72036           
  Misses             ?    32996           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86499a6...f65b0db. Read the comment docs.

Adds various boxed primitive type classes and
updates to CProver, Class and String.
@peterschrammel peterschrammel force-pushed the add-string-format-verification-tests branch from 29d4b46 to f65b0db Compare June 10, 2019 10:14
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f65b0db).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114923286

@peterschrammel peterschrammel merged commit cf0572e into diffblue:develop Jun 10, 2019
@peterschrammel peterschrammel deleted the add-string-format-verification-tests branch June 10, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants