Skip to content

Conversation

@tautschnig
Copy link
Collaborator

f14cd09 demoted some failures to warnings. This commit does so for
another case: if no body for the function is available, issue a warning
rather than failing an exception.

This situation will typically arise when using an unwindset
specification originally meant for CBMC with goto-instrument, where
library functions might not yet be present.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

f14cd09 demoted some failures to warnings. This commit does so for
another case: if no body for the function is available, issue a warning
rather than failing an exception.

This situation will typically arise when using an unwindset
specification originally meant for CBMC with goto-instrument, where
library functions might not yet be present.
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #6524 (5f33908) into develop (bb59fa6) will increase coverage by 0.00%.
The diff coverage is 93.44%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6524   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files         1576     1578    +2     
  Lines       180850   180910   +60     
========================================
+ Hits        137411   137467   +56     
- Misses       43439    43443    +4     
Impacted Files Coverage Δ
src/goto-instrument/unwindset.cpp 85.00% <33.33%> (-3.43%) ⬇️
src/goto-programs/remove_returns.cpp 98.15% <100.00%> (+0.02%) ⬆️
...smt2_incremental/construct_value_expr_from_smt.cpp 100.00% <100.00%> (ø)
...smt2_incremental/construct_value_expr_from_smt.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 198fd86...5f33908. Read the comment docs.

@tautschnig tautschnig merged commit e783d13 into diffblue:develop Dec 9, 2021
@tautschnig tautschnig deleted the unwindset-warnings-again branch December 9, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants