Skip to content

unwindset: Also warn about loops in functions without body #6524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tautschnig merged 1 commit into from
Dec 9, 2021
Merged

unwindset: Also warn about loops in functions without body #6524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/goto-instrument/unwindset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,21 @@ void unwindsett::parse_unwindset_one_loop(
std::string function_id = id.substr(0, last_dot_pos);
std::string loop_nr_label = id.substr(last_dot_pos + 1);

if(loop_nr_label.empty() || !goto_model.can_produce_function(function_id))
if(loop_nr_label.empty())
{
throw invalid_command_line_argument_exceptiont{
"invalid loop identifier " + id, "unwindset"};
}

if(!goto_model.can_produce_function(function_id))
{
messaget log{message_handler};
log.warning() << "loop identifier " << id
<< " for non-existent function provided with unwindset"
<< messaget::eom;
return;
}

const goto_functiont &goto_function =
goto_model.get_goto_function(function_id);
if(isdigit(loop_nr_label[0]))
Expand Down