secrets: add kvs flag for secrets get - #1943
Merged
Merged
Conversation
Adds a new `--kvs` flag for the `doctl secrets get` command which prints the secret values as `KEY=VALUE` pairs. For example, running: ```sh $ doctl secrets get --region tor1 --kvs my-secret ``` will output something like: ``` OTHER_KEY=a-value KEY=b-value ``` These will always print in alphabetical order.
Contributor
|
As I was writing my comment about alphabetical order I see you fixed it lol. But yeah this looks good. Idk why I didn't implement this the first time I went through this though... |
MaxLivesInTheMatrix
approved these changes
Sep 2, 2026
bentranter
marked this pull request as ready for review
September 2, 2026 17:55
sebnguyen
approved these changes
Sep 2, 2026
Contributor
|
It returns We could either short-circuit --kvs earlier or explicitly reject conflicting flags Otherwise LGTM |
Member
Author
|
Updated, thanks for the feedback @SSharma-10 |
Contributor
LGTM, thank you. |
SSharma-10
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
--kvsflag for thedoctl secrets getcommand which prints the secret values asKEY=VALUEpairs.For example, running:
will output something like:
These will always print in alphabetical order.