fix: rename teleop blueprints, remove VisualizingTeleopModule#1602
Merged
paul-nechifor merged 5 commits intodevfrom Mar 19, 2026
Merged
fix: rename teleop blueprints, remove VisualizingTeleopModule#1602paul-nechifor merged 5 commits intodevfrom
paul-nechifor merged 5 commits intodevfrom
Conversation
Contributor
Greptile SummaryThis PR cleans up the teleop module by removing the now-redundant
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant QB as Quest Browser (WebXR)
participant ATM as ArmTeleopModule
participant RB as RerunBridgeModule
participant LCM as LCM Transport
participant RR as Rerun Viewer
QB->>ATM: QuestControllerState (WebSocket)
ATM->>ATM: Frame transforms + engage logic
ATM->>LCM: PoseStamped (left/right_controller_output)
ATM->>LCM: Buttons
Note over RB: Subscribes to all LCM topics
LCM-->>RB: PoseStamped (auto-detected via to_rerun())
RB->>RR: rr.log(entity_path, pose.to_rerun())
Note over RB,RR: Button scalars, axes, etc. also logged if to_rerun() exists
Last reviewed commit: "fix: comments" |
mustafab0
approved these changes
Mar 19, 2026
paul-nechifor
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VisualizingTeleopModulewas redundant now that the Rerun bridge auto-visualizes allto_rerun()capable messages (including PoseStamped)Closes DIM-597
Solution
VisualizingTeleopModuleandteleop_visualization.py- replaced byrerun_bridge()inteleop_quest_rerunblueprintarm_teleop_visualizingblueprint (redundant)teleop_*prefixBreaking Changes
None (Blueprints are renamed, not called anywhere else)
How to Test
dimos run teleop-quest-rerunopens rerun,connect with meta quest, and shows quest controller poses in rerun
Contributor License Agreement