Merged
Conversation
leshy
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The xarm7(), xarm6(), and piper() catalog functions check if adapter_type="mock".
and if
global_config.simulationwas true, to setadapter_typeto sim on the 2nd check. so, test fails whenadaper_typeis set to mock and result wil besim, as env_variablesimis true.Solution
Removed the global_config.simulation swap from all three catalog functions and dropped the global_config import.
we dont set adapter, based on global_config.simulation for now
Breaking Changes
None
How to Test
Tests pass
SIMULATION=true pytest dimos/robot/test_robot_config.pySIMULATION=true pytest dimos/e2e_tests/test_control_coordinator.pyContributor License Agreement