Skip to content

fix(manip): tests#1774

Merged
ruthwikdasyam merged 2 commits intodevfrom
ruthwik/fix/manip_tests
Apr 11, 2026
Merged

fix(manip): tests#1774
ruthwikdasyam merged 2 commits intodevfrom
ruthwik/fix/manip_tests

Conversation

@ruthwikdasyam
Copy link
Copy Markdown
Contributor

@ruthwikdasyam ruthwikdasyam commented Apr 11, 2026

Problem

The xarm7(), xarm6(), and piper() catalog functions check if adapter_type="mock".
and if global_config.simulation was true, to set adapter_type to sim on the 2nd check. so, test fails when adaper_type is set to mock and result wil be sim, as env_variable sim is true.

Solution

Removed the global_config.simulation swap from all three catalog functions and dropped the global_config import.
we dont set adapter, based on global_config.simulation for now

Breaking Changes

None

How to Test

Tests pass
SIMULATION=true pytest dimos/robot/test_robot_config.py
SIMULATION=true pytest dimos/e2e_tests/test_control_coordinator.py

Contributor License Agreement

  • I have read and approved the CLA.

@ruthwikdasyam ruthwikdasyam marked this pull request as ready for review April 11, 2026 02:19
@ruthwikdasyam ruthwikdasyam enabled auto-merge (squash) April 11, 2026 02:20
@ruthwikdasyam ruthwikdasyam merged commit 4810c30 into dev Apr 11, 2026
3 of 4 checks passed
@ruthwikdasyam ruthwikdasyam deleted the ruthwik/fix/manip_tests branch April 11, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants