Build/cache native modules#2470
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2470 +/- ##
==========================================
+ Coverage 71.10% 71.53% +0.43%
==========================================
Files 897 897
Lines 80290 80290
Branches 7183 7186 +3
==========================================
+ Hits 57089 57435 +346
+ Misses 21319 20967 -352
- Partials 1882 1888 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Greptile SummaryThis PR adds a CI job that builds the
Confidence Score: 5/5Safe to merge — the workflow logic is sound, the fork-PR guard is correctly applied to both the marker and build jobs, and the previously flagged placeholder key has been replaced with a real Ed25519 public key. No functional defects found. The marker-cache skip pattern is correctly implemented (marker saved only on build success, looked up before building, consumed correctly by self-hosted-tests). The build script's discovery, parallelism, and early-exit logic are all correct. Version bumps are straightforward. The install-nix.sh defaults are safe no-ops when the variables are already set. No files require special attention. Important Files Changed
Reviews (8): Last reviewed commit: "Merge branch 'main' into sam/native-modu..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Problem
nav_stack tests are being skipped due to lack of native modules.
Solution
Build the modules in CI, cache the nix build in Cachix.