feat: nonblocking buffer readback#8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
GpuReadbacktype stages a buffer copy and returns immediately:request/request_copystart the transfer andtry_takepolls for completion (is_idlereports whether a readback is in flight).GpuTimestampsgained matchingrequest_read/try_take/is_idlefor non-blocking timestamp readback. Both are driven by a newBackend::pollmaintenance method (a non-blocking counterpart tosynchronize) implemented across the WebGPU, CUDA, Metal, and CPU backends. Themetalfeature now pulls inblockfor command-buffer completion handlers.WebGpu::from_device: build a WebGPU backend on top of an already-created wgpu instance/adapter/device/queue instead of creating its own.from_wgpuconstructors onGpuBufferSlice,GpuBufferSliceMut, andWebGpuBufferSliceto wrap a foreignwgpu::Buffer(owned by another library sharing the device) as a khal buffer slice.force_cpu_coroutinesoption for#[spirv_bindgen]: forces the CPU backend to dispatch a kernel through the coroutine scheduler sobarrier_wait()synchronizes, even for kernels with no#[spirv(workgroup)]parameter. Replaces the old dummy-workgroup-parameter hack.Fixed
_to names ending in a digit, so kernels likereduce_add_f32resolve correctly.