Use log facade in testbed2d. - #129
Conversation
|
Thanks, that's a good suggestion!
Definitely interested! |
|
Glad you like it. Issues to take into account :
I suggest to choose the most minimal one and add it as a dependency of all examples. simple-logger or env-logger are both good candidates. I chose env_logger arbitrarily (I like their documentation most) I will update the pull request with it. Also, by default, logs are set to a minimum, as per env_logger documentation :
So to enable them back, you have to invoke the examples like that: Perhaps the nphysics documentation should reflect that. |
To abstract out storage strategy for nphysics::World
131 testbed world owner
In order to avoid breaking changes, examples don't need modifications to compile and work!
131 merge for master
|
Thank you for your suggestion here. I am going to close this PR in favor of #143 which:
|
To illustrate what I'm suggesting with issue #128
I can make the same update for testbed3d if you're interested.