Address a few TODOs#273
Merged
ThierryBerger merged 9 commits intodimforge:masterfrom Nov 4, 2024
Merged
Conversation
ThierryBerger
commented
Sep 20, 2024
Comment on lines
82
to
83
| // TODO: use a Unit<Vector> instead. // TODO: Thierry: should we use Unit for [`Ray::dir`] too ? | ||
| pub normal: Vector<Real>, |
Contributor
Author
There was a problem hiding this comment.
not entirely trivial to do ; and will have API impacts
sebcrozet
reviewed
Nov 1, 2024
| #![deny(non_upper_case_globals)] | ||
| #![deny(unused_results)] | ||
| #![warn(missing_docs)] // TODO: deny this | ||
| #![deny(missing_docs)] |
Member
There was a problem hiding this comment.
Let’s keep this a warn and remove the TODO. I find it more convenient to just warn locally, and have it fail only on CI by denying warnings.
ThierryBerger
commented
Nov 8, 2024
ThierryBerger
commented
Nov 8, 2024
ThierryBerger
added a commit
to ThierryBerger/parry
that referenced
this pull request
Nov 8, 2024
ThierryBerger
added a commit
that referenced
this pull request
Nov 15, 2024
Contributor
|
Could we also have a PR for rapier that addresses the removal of Rapier doesn't just let me use the suggested visitor in place of this |
This was referenced Nov 25, 2024
Contributor
Author
|
Thanks @wlinna for bringing this to our attention!
|
This was referenced Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.