Move `fetchRolesTree`,`fetchGlobalAccess`, `fetchGlobalAccessForUser` and `fetchGlobalAccessForRoles` to the public utility package by ComfortablyCoding · Pull Request #26248 · directus/directus

ComfortablyCoding · 2025-11-24T17:21:20Z

Scope

What's changed:

Exposes fetchRolesTree, fetchGlobalAccess, fetchGlobalAccessForRoles and fetchGlobalAccessForUser to improve DX for building custom accountability in extensions.
Move ipInNetworks to utils

Potential Risks / Drawbacks

Something breaks due to not being transferred properly

Tested Scenarios

Lorem ipsum dolor sit amet
Consectetur adipiscing elit

Review Notes / Questions

The exported utilities are NOT cached like they are in core, this will need to be improved once we export cache utilities

Checklist

Added or updated tests
Documentation PR created here or not required
OpenAPI package PR created here or not required

Fixes CMS-1516

linear · 2025-11-24T17:21:23Z

CMS-1516 Export Require Core Utilities

codecov · 2025-11-24T18:13:23Z

Codecov Report

❌ Patch coverage is 79.03226% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.41%. Comparing base (523b6de) to head (ec3e206).
⚠️ Report is 4 commits behind head on main.

❌ Your patch status has failed because the patch coverage (64.40%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #26248      +/-   ##
==========================================
+ Coverage   59.30%   59.41%   +0.11%     
==========================================
  Files        2079     2080       +1     
  Lines      131592   131614      +22     
  Branches     7969     7983      +14     
==========================================
+ Hits        78038    78197     +159     
+ Misses      53554    53417     -137

Flag	Coverage Δ
api	`43.65% <64.40%> (+0.12%)`	⬆️
app	`70.61% <ø> (ø)`
composables	`82.25% <ø> (ø)`
create-directus-extension	`94.44% <ø> (ø)`
create-directus-project	`98.43% <ø> (ø)`
env	`99.67% <ø> (ø)`
errors	`97.47% <ø> (ø)`
extensions	`35.63% <ø> (ø)`
extensions-registry	`95.27% <ø> (ø)`
extensions-sdk	`14.38% <ø> (ø)`
format-title	`100.00% <ø> (ø)`
memory	`95.75% <ø> (ø)`
pressure	`77.63% <ø> (ø)`
release-notes-generator	`81.14% <ø> (ø)`
schema-builder	`80.59% <ø> (ø)`
sdk	`8.33% <ø> (ø)`
storage	`92.00% <ø> (ø)`
storage-driver-azure	`76.76% <ø> (ø)`
storage-driver-cloudinary	`81.14% <ø> (ø)`
storage-driver-gcs	`69.72% <ø> (ø)`
storage-driver-local	`69.76% <ø> (ø)`
storage-driver-s3	`46.73% <ø> (ø)`
storage-driver-supabase	`68.20% <ø> (ø)`
system-data	`71.81% <ø> (ø)`
update-check	`55.67% <ø> (ø)`
utils	`90.20% <92.30%> (+3.03%)`	⬆️
validation	`44.50% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

packages/utils/node/fetch-global-access/lib/fetch-global-access-for-user.ts

packages/utils/node/fetch-global-access/lib/fetch-global-access-for-roles.ts

.changeset/silver-steaks-tease.md

br41nslug

Code is looking great, just have a couple small comments/questions

api/src/permissions/utils/with-cache.ts

api/src/permissions/modules/fetch-global-access/fetch-global-access.ts

Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>

packages/utils/node/fetch-roles-tree.ts

AlexGaillard

🆒🫘

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [directus/directus](https://github.com/directus/directus) | minor | `11.13.4` -> `11.14.0` | --- ### Release Notes <details> <summary>directus/directus (directus/directus)</summary> ### [`v11.14.0`](https://github.com/directus/directus/releases/tag/v11.14.0) [Compare Source](directus/directus@v11.13.4...v11.14.0) ##### ⚠️ Potential Breaking Changes - **[@directus/stores](https://github.com/directus/stores)** - Removed sidebar states from app store ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) ##### ✨ New Features & Improvements - **[@directus/app](https://github.com/directus/app)** - Added support for downloading multiple files and entire folder trees ([#26006](directus/directus#26006) by [@Nitwel](https://github.com/Nitwel)) - Added AI chat sidebar ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) - Added support for float intervals and min/max warnings for number inputs ([#26190](directus/directus#26190) by [@gaetansenn](https://github.com/gaetansenn)) - Made both sidebars resizable ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) - Added header interface ([#26302](directus/directus#26302) by [@AlexGaillard](https://github.com/AlexGaillard)) - **[@directus/api](https://github.com/directus/api)** - Added support for downloading multiple files and entire folder trees ([#26006](directus/directus#26006) by [@Nitwel](https://github.com/Nitwel)) - Added AI chat sidebar ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) - **[@directus/types](https://github.com/directus/types)** - Added support for downloading multiple files and entire folder trees ([#26006](directus/directus#26006) by [@Nitwel](https://github.com/Nitwel)) - Added AI chat sidebar ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) - **[@directus/utils](https://github.com/directus/utils)** - Added support for downloading multiple files and entire folder trees ([#26006](directus/directus#26006) by [@Nitwel](https://github.com/Nitwel)) - Moved `fetchRolesTree`,`fetchGlobalAccess`, `fetchGlobalAccessForUser` and `fetchGlobalAccessForRoles` to the public utility package ([#26248](directus/directus#26248) by [@ComfortablyCoding](https://github.com/ComfortablyCoding)) - **[@directus/sdk](https://github.com/directus/sdk)** - Added support for downloading multiple files and entire folder trees ([#26006](directus/directus#26006) by [@Nitwel](https://github.com/Nitwel)) - **[@directus/system-data](https://github.com/directus/system-data)** - Added AI chat sidebar ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) - **[@directus/errors](https://github.com/directus/errors)** - Added AI chat sidebar ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) - **[@directus/themes](https://github.com/directus/themes)** - Added AI chat sidebar ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) ##### 🐛 Bug Fixes & Optimizations - **[@directus/app](https://github.com/directus/app)** - Fixed an issue where input focus ring disappears on hover ([#26315](directus/directus#26315) by [@formfcw](https://github.com/formfcw)) - Fixed display template not appearing for relations inside translations on new items ([#26219](directus/directus#26219) by [@gaetansenn](https://github.com/gaetansenn)) - Ensured the created revision uses the correct label ([#26289](directus/directus#26289) by [@vizzv](https://github.com/vizzv)) - Added reactive primaryKey prop to useFlows composable ([#26287](directus/directus#26287) by [@AlexGaillard](https://github.com/AlexGaillard)) - **[@directus/api](https://github.com/directus/api)** - Added redirect validation ([#26346](directus/directus#26346) by [@br41nslug](https://github.com/br41nslug)) - Moved `fetchRolesTree`,`fetchGlobalAccess`, `fetchGlobalAccessForUser` and `fetchGlobalAccessForRoles` to the public utility package ([#26248](directus/directus#26248) by [@ComfortablyCoding](https://github.com/ComfortablyCoding)) - Updated synchronization of remotely stored extensions ([#26192](directus/directus#26192) by [@br41nslug](https://github.com/br41nslug)) - Fixed missing accountability for `files.upload` when TUS is enabled ([#26247](directus/directus#26247) by [@br41nslug](https://github.com/br41nslug)) - **[@directus/types](https://github.com/directus/types)** - Moved `fetchRolesTree`,`fetchGlobalAccess`, `fetchGlobalAccessForUser` and `fetchGlobalAccessForRoles` to the public utility package ([#26248](directus/directus#26248) by [@ComfortablyCoding](https://github.com/ComfortablyCoding)) - Updated synchronization of remotely stored extensions ([#26192](directus/directus#26192) by [@br41nslug](https://github.com/br41nslug)) - **[@directus/storage-driver-cloudinary](https://github.com/directus/storage-driver-cloudinary)** - Updated synchronization of remotely stored extensions ([#26192](directus/directus#26192) by [@br41nslug](https://github.com/br41nslug)) - **[@directus/storage-driver-supabase](https://github.com/directus/storage-driver-supabase)** - Updated synchronization of remotely stored extensions ([#26192](directus/directus#26192) by [@br41nslug](https://github.com/br41nslug)) - **[@directus/extensions-sdk](https://github.com/directus/extensions-sdk)** - Updated `esbuild` dependency from 0.25.12 to 0.26.0 ([#26215](directus/directus#26215) by [@dependabot](https://github.com/dependabot)) - **[@directus/system-data](https://github.com/directus/system-data)** - Updated `esbuild` dependency from 0.25.12 to 0.26.0 ([#26215](directus/directus#26215) by [@dependabot](https://github.com/dependabot)) - **[@directus/sdk](https://github.com/directus/sdk)** - Updated `esbuild` dependency from 0.25.12 to 0.26.0 ([#26215](directus/directus#26215) by [@dependabot](https://github.com/dependabot)) - **[@directus/themes](https://github.com/directus/themes)** - Made both sidebars resizable ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) - **[@directus/utils](https://github.com/directus/utils)** - Preserved Error when passed to run-script operation ([#26234](directus/directus#26234) by [@gaetansenn](https://github.com/gaetansenn)) - **[@directus/composables](https://github.com/directus/composables)** - Set default sidebar shadow to false ([#26259](directus/directus#26259) by [@rijkvanzanten](https://github.com/rijkvanzanten)) ##### 📦 Published Versions - `@directus/app@14.4.0` - `@directus/api@32.2.0` - `@directus/composables@11.2.8` - `create-directus-extension@11.0.24` - `@directus/env@5.3.3` - `@directus/errors@2.1.0` - `@directus/extensions@3.0.15` - `@directus/extensions-registry@3.0.15` - `@directus/extensions-sdk@17.0.4` - `@directus/memory@3.0.13` - `@directus/pressure@3.0.13` - `@directus/schema-builder@0.0.10` - `@directus/storage-driver-azure@12.0.13` - `@directus/storage-driver-cloudinary@12.0.13` - `@directus/storage-driver-gcs@12.0.13` - `@directus/storage-driver-s3@12.0.13` - `@directus/storage-driver-supabase@3.0.13` - `@directus/stores@2.0.0` - `@directus/system-data@3.5.0` - `@directus/themes@1.2.0` - `@directus/types@13.5.0` - `@directus/utils@13.1.0` - `@directus/validation@2.0.13` - `@directus/sdk@20.3.0` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/2365 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

ComfortablyCoding added 3 commits November 20, 2025 16:54

move ipinnetworks to utils package

2b512a7

extract fetchRolesTree to utils

2e483ef

extract fetchGlobalAccess to utils

3e85157

ComfortablyCoding requested a review from AlexGaillard as a code owner November 24, 2025 17:21

ComfortablyCoding added 3 commits November 24, 2025 12:24

add changeset

ed9aef6

Fix tests

7ce5192

Fix tests again

73e80cf

Merge branch 'main' into expose-accountability-utilities

923f053

AlexGaillard requested a review from br41nslug November 24, 2025 19:19

br41nslug reviewed Nov 24, 2025

View reviewed changes

packages/utils/node/fetch-global-access/lib/fetch-global-access-for-user.ts Show resolved Hide resolved

packages/utils/node/fetch-global-access/lib/fetch-global-access-for-roles.ts Show resolved Hide resolved

ComfortablyCoding added 6 commits November 24, 2025 20:19

Add support for withCache to use any params for memoization

4bc09e6

add basic withCache tests

50e0ee2

Simplify interfaces

8519430

Update relevent tests

18a5c0c

Ensure no attempt to memoize not stringifiable data

6dea875

Improve function comments

c42e13e

ComfortablyCoding requested a review from br41nslug November 25, 2025 01:54

ComfortablyCoding added the Run Blackbox label Nov 25, 2025

ComfortablyCoding commented Nov 25, 2025

View reviewed changes

.changeset/silver-steaks-tease.md Outdated Show resolved Hide resolved

br41nslug reviewed Nov 25, 2025

View reviewed changes

api/src/permissions/utils/with-cache.ts Outdated Show resolved Hide resolved

api/src/permissions/utils/with-cache.ts Outdated Show resolved Hide resolved

api/src/permissions/modules/fetch-global-access/fetch-global-access.ts Show resolved Hide resolved

ComfortablyCoding and others added 2 commits November 25, 2025 15:19

Update api/src/permissions/utils/with-cache.ts

14a8fc9

Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>

Update api/src/permissions/utils/with-cache.ts

9608b4b

Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>

br41nslug approved these changes Nov 25, 2025

View reviewed changes

Update .changeset/silver-steaks-tease.md

e752969

ComfortablyCoding changed the title ~~Expose core accountability utilities~~ Move fetchRolesTree,fetchGlobalAccess, fetchGlobalAccessForUser and fetchGlobalAccessForRoles to the public utility package Nov 26, 2025

AlexGaillard requested changes Nov 26, 2025

View reviewed changes

packages/utils/node/fetch-roles-tree.ts Outdated Show resolved Hide resolved

Update packages/utils/node/fetch-roles-tree.ts

ec3e206

AlexGaillard approved these changes Nov 26, 2025

View reviewed changes

AlexGaillard merged commit b5b80b7 into main Nov 26, 2025
74 of 75 checks passed

AlexGaillard deleted the expose-accountability-utilities branch November 26, 2025 18:10

github-actions bot added this to the Next Release milestone Nov 26, 2025

github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move `fetchRolesTree`,`fetchGlobalAccess`, `fetchGlobalAccessForUser` and `fetchGlobalAccessForRoles` to the public utility package#26248

Move `fetchRolesTree`,`fetchGlobalAccess`, `fetchGlobalAccessForUser` and `fetchGlobalAccessForRoles` to the public utility package#26248
AlexGaillard merged 17 commits intomainfrom
expose-accountability-utilities

ComfortablyCoding commented Nov 24, 2025 •

edited

Loading

Uh oh!

linear bot commented Nov 24, 2025

Uh oh!

codecov bot commented Nov 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

br41nslug left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexGaillard left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ComfortablyCoding commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scope

Potential Risks / Drawbacks

Tested Scenarios

Review Notes / Questions

Checklist

Uh oh!

linear bot commented Nov 24, 2025

Uh oh!

codecov bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

br41nslug left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexGaillard left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ComfortablyCoding commented Nov 24, 2025 •

edited

Loading

codecov bot commented Nov 24, 2025 •

edited

Loading