core/internal/array/utils.d: TraceHook support types with quotes in name - #21510
Conversation
|
Thanks for your pull request and interest in making D better, @the-horo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#21510" |
|
If you need this for CI, do you want to target stable? |
|
Nah, the dcd CI has been silently failing for a while (probably), I'm in no rush. Maybe the dcd maintainers would me interested though... |
|
It should be failing since dlang-community/libdparse@92df030 from 2024-04 so >1 year ago |
|
Well, we're about to have a release so it would be good to have, and unlikely to cause problems. |
Avoid directly mixin'ing the result of T.stringof for arbitrary types since that proves problematic with string parameters to templates with their quote and other special characters. Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
Avoid directly mixin'ing the result of T.stringof for arbitrary types since that proves problematic with string parameters to templates with their quote and other special characters.
I've hit this in the CI of dcd where
dub build --profile=gcfails with: