Fix incorrect sign for expanding arrays into subsequent pages - #21616
Merged
Conversation
|
Thanks for your pull request, @schveiguy! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
schveiguy
force-pushed
the
fix-array-extend-21615
branch
from
July 28, 2025 21:13
3fff564 to
00b3f46
Compare
appending to a large array that could potentially use extend, when the requested array size is within a certain size for a multiple of pages. The calculation had the wrong sign for the large padding (the 2 size_t + 1 byte), which made it end up sending a number very close to size_t.max into the extend function. This affected both appending and setting length performance, though appending also had a grow factor which may have mitigated this somewhat.
schveiguy
force-pushed
the
fix-array-extend-21615
branch
from
July 28, 2025 21:14
00b3f46 to
353f5d5
Compare
dkorpel
approved these changes
Jul 28, 2025
Member
|
Stable ? |
Contributor
|
It's targeting 2.112.0 either way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dumb sign error...