Fix missing eSink assignment in cppwin.d - #23405
Merged
Merged
Conversation
Contributor
Author
|
Compile dtoh_ignored.d without Take a look at the code, it's a missed assignment. EDIT: this is for the ICE, for the difference in behaviour, same test case, but it is a different cause. |
thewilsonator
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an ICE that can be triggered due to null deref from a missing assignment in constructor.
However there is a bigger problem, if you compile dtoh_ignored.d without
-o-you will get errors, that don't exist with it.Mangler can error due to complex number types getting mangled as c++.
I won't be fixing this problem.