druntime: Move accumulatePure from core.internal.array to rt.profilegc#23408
Open
QuantumSegfault wants to merge 7 commits into
Open
druntime: Move accumulatePure from core.internal.array to rt.profilegc#23408QuantumSegfault wants to merge 7 commits into
accumulatePure from core.internal.array to rt.profilegc#23408QuantumSegfault wants to merge 7 commits into
Conversation
Contributor
Author
`rt.profilegc`
QuantumSegfault
force-pushed
the
move-accumulate-pure
branch
from
July 17, 2026 20:42
3ee42d9 to
e5684b4
Compare
thewilsonator
approved these changes
Jul 17, 2026
Contributor
|
cc @dkorpel as you wrote the fix for master, and this PR seems to do it slightly differently to what you did (and may cause merge conflicts). |
This reverts commit 5f9d508.
Contributor
Author
|
This hasn't been working so far. CTFE tries to instantiate the hooks, causing weird bugs. |
Contributor
Author
|
Okay, I think I coaxed it into working...still some test failures to figure out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
accumulatePure(which is a thin wrapper aroundrt.profilegc.accumulate, adding forcing purity on it) out ofcore.internal.arrayand intort.profilegc.This helps prevent
rt.profilegcfrom being dragged in (and thus its module destructors) whenD_ProfileGCisn't enabled, reducing the size of statically linked binaries.See ldc-developers/ldc#5186 (comment)
This problem should be solved on
masterby #22859. This improvement is for 1.113.