osthread: divides some another piece of OS-related code over *_impl modules - #23516
Open
denizzzka wants to merge 3 commits into
Open
osthread: divides some another piece of OS-related code over *_impl modules#23516denizzzka wants to merge 3 commits into
denizzzka wants to merge 3 commits into
Conversation
rikkimax
reviewed
Aug 3, 2026
| } | ||
|
|
||
| version (CoreDdoc) {} else | ||
| public alias getpid = imported!"core.sys.windows.winbase".GetCurrentProcessId; |
Contributor
There was a problem hiding this comment.
Why are these not public imports?
denizzzka
force-pushed
the
osthread_next_split
branch
from
August 3, 2026 19:49
0244a0d to
2b4289a
Compare
denizzzka
force-pushed
the
osthread_next_split
branch
from
August 3, 2026 20:04
2b4289a to
2cf6a09
Compare
denizzzka
commented
Aug 3, 2026
| version (CoreDdoc) | ||
| { | ||
| alias getpid = imported!"core.sys.windows.winbase".GetCurrentProcessId; | ||
| size_t getpid() nothrow @nogc { return 0; } |
Contributor
Author
There was a problem hiding this comment.
I don't know what return type to put here because implementation may be different for different platforms, so I wrote size_t
denizzzka
commented
Aug 3, 2026
| // Call these routines when entering/leaving critical sections of the code that | ||
| // are not cancellation points. | ||
|
|
||
| extern (C) int thread_cancelDisable() nothrow |
Contributor
Author
There was a problem hiding this comment.
Why we declare thread_cancelDisable() and thread_cancelRestore() as public?
denizzzka
force-pushed
the
osthread_next_split
branch
from
August 3, 2026 20:49
8d8cd57 to
386da2c
Compare
denizzzka
changed the title
denizzzka
marked this pull request as ready for review
August 3, 2026 20:57
denizzzka
force-pushed
the
osthread_next_split
branch
from
August 4, 2026 10:36
386da2c to
a627a21
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is happening is part of the process of separating code from different platforms into different modules
Only 2 or 3 similar PRs left for the
osthreadmodule