changelog: fix grammar and naming in pending entries - #23530
Open
dkorpel wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
thewilsonator
left a comment
thewilsonator
left a comment
Contributor
There was a problem hiding this comment.
otherwise looks good
Comment on lines
+4
to
+6
| The intent of the engine is to be both fast and free from false positives; if successful, it may in the future be turned on by default. | ||
|
|
||
| No attributes have been implemented to date, before they are considered the engine itself must be both usable with the right tradeoffs and have desirable features. | ||
| This has some side effects, it prevent separate compilation, function pointers, and cyclic functions from being analysable. | ||
| No attributes have been implemented to date; before they are considered, the engine itself must be both usable with the right tradeoffs and have desirable features. |
Contributor
There was a problem hiding this comment.
what's with the semi colons? The first one should be full stop, the second one should be a comma.
| Only in a mathematical expression. | ||
|
|
||
| This was not originally part of the fast DFA engines scope, its continued existence depends upon community feedback as part of usage. | ||
| This was not originally part of the fast DFA engine's scope; its continued existence depends upon community feedback as part of usage. |
Contributor
There was a problem hiding this comment.
semi-colon should be a full stop
PetarKirov
added a commit
to PetarKirov/sparkles
that referenced
this pull request
Aug 7, 2026
Where a reviewer reads them: under the anchor line, not in a margin and not in a separate pane where the code they refer to has scrolled away (the Gerrit `gr-diff` shape). A thread on the old side hangs on the removed line its author actually saw, never on the new one. A resolved thread folds to one line. Not tidiness: an unresolved conversation is a thing the reviewer must ACT on, and rendering a settled argument at the same weight buries the live one. The badge still says who and how many - the demote-never-hide contract `DVN2` already holds for noise. `AnchoredThread` is forge-neutral and lives with the session, so `DCM2`'s local comments will produce exactly the same value: no forge type reaches the renderer, and a locally-authored thread is not a second kind of thing. That is what "the thread block is one widget" has to mean to be worth saying. Comment bodies are markdown, rendered through hue's own view - the one place it would be strange for markdown not to be markdown. Verified live on dlang/dmd#23530 (this repository has no PR with review threads to test against). The live run also corrected the indentation mechanism: a prefix span only ever lands on the FIRST row of a wrapped body, leaving the rest hanging at the code's own column where it reads as code. Padding indents every row. Claude-Session: https://claude.ai/code/session_01YQJw7nA1exWvgh7w5tEZsu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed by Claude for the 2.113 beta