Skip to content

remove warningxxxx() from errors.d - #23740

Merged
thewilsonator merged 1 commit into
dlang:masterfrom
WalterBright:rmwarning
Sep 3, 2026
Merged

remove warningxxxx() from errors.d#23740
thewilsonator merged 1 commit into
dlang:masterfrom
WalterBright:rmwarning

Conversation

@WalterBright

Copy link
Copy Markdown
Member

Start removing all the error message functions that are not derived from ErrorSink. I couldn't go further with this at the moment because #23654 is not merged yet.

@thewilsonator

Copy link
Copy Markdown
Contributor

warning is still used in LDC

% git grep "warning("
...
gen/abi/abi.cpp:    warning(Loc(),
gen/functions.cpp:    warning(fd->loc,
gen/ldctraits.d:            warning(e.loc, "ignoring arguments for __traits %s", e.ident.toChars());
gen/pgo_ASTbased.cpp:      warning(fd->loc,
gen/pgo_ASTbased.cpp:      warning(fd->loc,
gen/pgo_ASTbased.cpp:      warning(fd->loc, "Error loading profile data for function `%s` (`%s`)",
gen/pragma.cpp:    warning(s->loc,
gen/target.cpp:    warning(Loc(), "unknown properties for target `real` type, relying on D "
gen/uda.cpp:    warning(sle->loc,
gen/uda.cpp:    warning(sle->loc,
gen/uda.cpp:      warning(sle->loc,
gen/uda.cpp:        warning(sle->loc,
gen/uda.cpp:        warning(sle->loc,
gen/uda.cpp:    warning(sle->loc, "ignoring unrecognized calling convention name '%s' for "
gen/uda.cpp:      warning(sle->loc,
...

@WalterBright

Copy link
Copy Markdown
Member Author

I added a version(LDC)

@WalterBright WalterBright added the Review:Ready To Merge Let's get this merged label Aug 31, 2026
@thewilsonator
thewilsonator merged commit a1544f7 into dlang:master Sep 3, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review:Easy Review Review:Ready To Merge Let's get this merged Severity:Refactoring No semantic changes to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants