Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5722856 bin/dub
rough build time=53sFull build output |
ghost
changed the title
| f.writeln(" command = ", compiler, " $flags -c $in -of=$out"); | ||
| f.writeln(" command = ", compiler, " $flags -c $in -of=$out -makedeps=$out.dep"); | ||
| f.writeln(" depfile = $out.dep"); | ||
| f.writeln(" deps = gcc"); |
Contributor
There was a problem hiding this comment.
what is this line for?
Author
There was a problem hiding this comment.
deps = gcc tells Ninja to parse the depfile in gcc/Makefile format (vs MSVC's /showIncludes). Combined with depfile = $out.dep, it lets Ninja pick up implicit dependencies from the -makedeps output — e.g. string imports like views/data.txt — so those trigger rebuilds too, not just the direct source file. This is validated across Windows too, not just Linux — the behavioral test passes on 8 different Windows compiler configs (dmd 2.100–latest, ldc 1.30–master); the only Windows failure is an unrelated LNK1318 linker flake in a different test.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds -makedeps dependency tracking to the ninja dc rule so ninja
can track implicit dependencies (string imports, headers) and
trigger incremental rebuilds correctly.
Also fixes a bug where -J flags for stringImportPaths were not
being emitted, which would silently break any project using
string imports.
Test: builds a project with a string import, runs it to verify
output matches the imported file content, modifies the file,
rebuilds, and asserts the output changed — proving dependency
tracking works end-to-end.