feat: handle sub-packages in ninja generator - #3133
Merged
Merged
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5722856 bin/dub
rough build time=62sFull build output |
thewilsonator
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles sub-packages in the ninja generator: sanitizes colon/slash
characters in target names, computes link dependencies for sub-package
.a archives, and links them into the parent executable.
Builds on the ar rule from #3132 (merged). Independent of #3130
(unmerged, not in this branch's history).
Test builds a sub-package as a static library, links it into an
executable via the ar rule, and runs the linked binary, asserting a
real computed result (add(1,2)==3) rather than just checking the
binary exists or exits 0. Verified to fail when the sub-package logic
is broken, and to pass on a fresh clone independent of local
working-tree state.