Skip to content

Reapply "Improved css reset for default.css" - #7372

Open
bdukes wants to merge 2 commits into
dnnsoftware:developfrom
bdukes:css-reset-fix
Open

Reapply "Improved css reset for default.css"#7372
bdukes wants to merge 2 commits into
dnnsoftware:developfrom
bdukes:css-reset-fix

Conversation

@bdukes

@bdukes bdukes commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This reverts commit c5f81dd.

Second try for #7371

@bdukes bdukes added this to the 10.4.0 milestone Jul 14, 2026
valadas
valadas previously approved these changes Jul 23, 2026
@Timo-Breumelhof

Copy link
Copy Markdown
Contributor

It's this one, I guess. https://cdn.jsdelivr.net/npm/modern-normalize/modern-normalize.css
Yes that will fix the issue.
Might lead to other ones though, we'll see.
As I said before, I would remove it as IMO it's the theme's responsibility to load a reset.css

@Timo-Breumelhof

Copy link
Copy Markdown
Contributor

@bdukes @valadas
I tested some more with the same theme (BS5)
Without the current reset (custom default.css) my aligment issues in tabels are fixed but some elements (in FF) get borders they did not have before. This is also the case with this new reset.

Looked like this:

image

Without reset or with the new one included:

image

I think my initial issue are caused by the DNN 7 default.css not having a border reset for td and the current version does.
This new one however does not reset borders to 0 and thus unexpected borders show up in some places.

Not sure I would add this new reset to DNN 10.4 THB and I think the "no risk" fix would be to not remove baseline like I did here:

#7406

But remove the lines for tables as they are a change.
image

And then postpone a more modern version to DNN 11?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants