[20.10 backport] Fix incorrect pointer inputs to json.Unmarshal - #3522
Merged
thaJeztah merged 1 commit intoApr 14, 2022
Merged
Conversation
See https://github.com/howardjohn/go-unmarshal-double-pointer for more info on why this is not safe and how this is detected. Signed-off-by: John Howard <howardjohn@google.com> (cherry picked from commit ee97fe9) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ndeloof
approved these changes
Apr 14, 2022
rumpl
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #3434
See https://github.com/howardjohn/go-unmarshal-double-pointer for more
info on why this is not safe and how this is detected.
(cherry picked from commit ee97fe9)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)