Lower case "order by" keyword causes wrong LIMIT query on SQL Server

[stchr]

SQLServerPlatform::modifyLimitQuery('SELECT * FROM user order by username') (lowercase order by)
returns
SELECT * FROM (SELECT *, ROW_NUMBER() OVER (ORDER BY order) AS doctrine_rownum FROM user order by username) AS doctrine_tbl WHERE doctrine_rownum BETWEEN 1 AND 10
instead of
SELECT * FROM (SELECT *, ROW_NUMBER() OVER (ORDER BY username) AS doctrine_rownum FROM user) AS doctrine_tbl WHERE doctrine_rownum BETWEEN 1 AND 10

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-862

We use Jira to track the state of pull requests and the versions they got
included in.

[Ocramius]

I just noticed it, but the regex doesn't seem to enforce at least one whitespace before the ORDER BY clause

[stchr]

The regex in line 1153 already enforces one whitespace before ORDER BY.
If you also enforce a whitespace in the regex in line 1172, it will break. Maybe the stristr($query, ' ORDER BY') in line 1152 may get an prefixed whitespace

[Ocramius]

@stchr yeah, re-read it and it seems like it's indeed ok.

[Ocramius]

@deeky666 mergeable

[deeky666]

looks good to me