Skip to content

Conversation

@rejuvyesh
Copy link
Contributor

We should be extending Base.step and Base.reset (I'm on Julia v1.7.2). I would recommend Squash and Merge for this PR because I accidentally added and reverted a local thing I was testing.

@rejuvyesh
Copy link
Contributor Author

Also would be great if you could change your security settings to allow my (and other contributors') PRs to run CI!

@simon-lc
Copy link
Member

simon-lc commented Mar 7, 2022

Thanks for your help!

@simon-lc simon-lc merged commit c752e67 into dojo-sim:main Mar 7, 2022
@simon-lc
Copy link
Member

simon-lc commented Mar 7, 2022

@rejuvyesh Hi Jayesh, I am sorry I am very new to this, we have this setting for the contributors' PRs:
Screenshot from 2022-03-07 15-22-37
I am not sure but we had a check in CI.yml that might have prevented CI to test your PR. I removed it so hopefully this make things easier on your side!
Please tell me if I need to do anything else to ease the process

@rejuvyesh
Copy link
Contributor Author

rejuvyesh commented Mar 7, 2022

I think changing it to require approval for "first-time contributors who are new to GitHub" is the recommended option. This way most accounts that have been using GitHub for a while, when they make a PR, should be able to have CI run for their PR as well. But just for me, your selected option is fine too!

@simon-lc
Copy link
Member

simon-lc commented Mar 8, 2022

Thanks for the explanation! I've just made the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants