Skip to content

Don't shadow Base functions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-lc merged 3 commits into from
Mar 7, 2022
Merged

Don't shadow Base functions #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f325e4
add folds
rejuvyesh Mar 7, 2022
147d5cc
Don't shadow base functions, rather extend them
rejuvyesh Mar 7, 2022
d8d4c79
Revert "add folds"
rejuvyesh Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions environments/environment.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ end
gradients: flag for computing gradients of dynamics
attitude_decompress: flag for pre- and post-concatenating Jacobians with attitude Jacobians
"""
function step(env::Environment, x, u;
function Base.step(env::Environment, x, u;
gradients=false,
attitude_decompress=false)

Expand Down Expand Up @@ -108,7 +108,7 @@ function step(env::Environment, x, u;
return get_observation(env), -costs, done, info
end

function step(env::Environment, u;
function Base.step(env::Environment, u;
gradients=false,
attitude_decompress=false)
step(env, env.state, u;
Expand Down Expand Up @@ -155,7 +155,7 @@ is_done(env::Environment, x) = false
env: Environment
x: state
"""
function reset(env::Environment{X};
function Base.reset(env::Environment{X};
x=nothing) where X

initialize!(env.mechanism, type2symbol(X))
Expand Down
4 changes: 2 additions & 2 deletions src/Dojo.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,11 @@ export
dynamics_jacobian_state,
dynamics_jacobian_input,
get_environment,
step,
#step,
get_observation,
cost,
is_done,
reset,
#reset,
render,
seed,
close,
Expand Down