fix: plug fd leak in TomlSet and clean failed install dirs - #287
Merged
Conversation
The encoder error in `TomlSet` triggered `log.Fatal` before the explicit `f.Close()` ran, leaking the file descriptor and any unflushed writes. The bash `install` command also left a partially extracted directory under `$PLUGIN_PATH/available/` when `curl | tar xz` failed, which then blocked any retry through the "already installed" branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoder error in
TomlSettriggeredlog.Fatalbefore the explicitf.Close()ran, leaking the file descriptor and any unflushed writes. The bashinstallcommand also left a partially extracted directory under$PLUGIN_PATH/available/whencurl | tar xzfailed, which then blocked any retry through the "already installed" branch.