Skip to content

Nightly build ref: add --first-parent to midnight commit selection #37202

Description

@sfreudenthaler

Part of dotCMS/private-issues#673.

.github/workflows/cicd_4-nightly.yml:110 selects the build ref with git log --before=midnight -1. Under merge commits, intermediate branch commits are reachable from main, so the nightly can build a mid-branch tree that never existed as main's tip and never passed the merge queue.

Fix: add --first-parent (both the --before lookup and the fallback at line 115). Safe to land now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions